Bug 247332
| Summary: | Checking m_defaultPageGroup->preferences() in WebProcessPool::platformInitializeWebProcess() is probably wrong | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | WebKit Process Model | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | pvollan, simon.fraser, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
WebProcessPool::platformInitializeWebProcess() does:
if (m_defaultPageGroup->preferences().useGPUProcessForDOMRenderingEnabled())
parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();
but m_defaultPageGroup->preferences() is uninitialized at this point, so this condition is never hit.
The same applies to checks for mediaDevicesEnabled and captureAudioInGPUProcessEnabled lower down.
Behavior might be different in different UI apps (depending on their use of the API). I reproduced the issue in MiniBrowser on macOS.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101821075>
Simon Fraser (smfr)
I confirmed that m_defaultPageGroup->preferences() is empty when launching MobileSafaro too, so these checks are certainly wrong.
Simon Fraser (smfr)
The config in MobileSafari is such that these checks succeed.
Per Arne Vollan
*** This bug has been marked as a duplicate of bug 257750 ***