| Summary: | Code style does not allow currently used member function explanation comments for vfuncs, ipc messages | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Tools / Tests | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Pull request: https://github.com/WebKit/WebKit/pull/5996 Committed 256221@main (09420100638c): <https://commits.webkit.org/256221@main> Reviewed commits have been landed. Closing PR #5996 and removing active labels. |
Code style does not allow currently used member function explanation comments for vfuncs, ipc messages Current style defines that comments must be English sentences. Currently code uses: class GPUProcessConnection : public RefCounted<GPUProcessConnection>, public IPC::Connection::Client { public: /// ... // IPC::Connection::Client void didClose(IPC::Connection&) override; // ... }; When trying to solve this by using: // IPC::Connection::Client overrides. .. then some reviewer complains. When trying to solve this by using: // IPC::Connection::Client .. then another reviewer complains. It is not good that review results of seemingly deterministic rule-based system depends on personal preferences of who happens to review the patch. This causes non-deterministic churn during reviews. The code style could define this case so that there would be no need for personal preferences.