| Summary: | Add support for Fetch Priority | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Meenan <patmeenan> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | achristensen, annevk, annulen, barry, cdumez, changseok, clopez, esprehn+autocc, ews-watchlist, gyuyoung.kim, karlcow, koivisto, kondapallykalyan, rbuis, rik, rniwa, ryuan.choi, sergio, steven, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 254028, 252739, 255008 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Patrick Meenan
2022-10-31 14:58:56 PDT
Created attachment 464982 [details]
Patch
Pull request: https://github.com/WebKit/WebKit/pull/10084 FYI, there is discussion on the HTML spec PR about removing it from iFrame and leaving it as a hint for same-document subresources and exploring iFrame scheduling separately. https://github.com/whatwg/html/pull/8470#discussion_r1106835444 I imagine that WebKit has a lot of similar details to Chrome for why prioritizing the fetch of the iFrame navigation resource might be ineffective and not do what the site devs are trying to achieve (prioritizing across frame boundaries at the document and network level probably won't do anything in Chrome for example). Script, IMG and Link tag fetchpriority attributes (as well as fetch RequestInit) all still have very clear use cases though. (In reply to Patrick Meenan from comment #4) > FYI, there is discussion on the HTML spec PR about removing it from iFrame > and leaving it as a hint for same-document subresources and exploring iFrame > scheduling separately. > > https://github.com/whatwg/html/pull/8470#discussion_r1106835444 > > I imagine that WebKit has a lot of similar details to Chrome for why > prioritizing the fetch of the iFrame navigation resource might be > ineffective and not do what the site devs are trying to achieve > (prioritizing across frame boundaries at the document and network level > probably won't do anything in Chrome for example). > > Script, IMG and Link tag fetchpriority attributes (as well as fetch > RequestInit) all still have very clear use cases though. Thanks for the link! As it happens I did not start on making iframe + priority hints work because, I guess like others found out, it would be a lot more changes/plumbing to make that work. I would be fine too of course removing the idl for it. Committed 260666@main (adf13d454519): <https://commits.webkit.org/260666@main> Reviewed commits have been landed. Closing PR #10084 and removing active labels. Still needs implementation. Comment on attachment 464982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464982&action=review > Source/WebCore/Modules/fetch/RequestPriority.idl:28 > + "high" Someone pointed out on Slack that this is missing commas between the values, please follow-up and fix. I implemented the feature, but don't have the expertise to work on bug 254028, so I am removing myself as assignee. FYI, in Chrome we're trying to consolidate on "Fetch Priority" and avoid using "Priority Hints" going forward to reduce developer confusion. More info: - https://twitter.com/tunetheweb/status/1648399924424237058?s=20 - https://web.dev/fetch-priority/#history Closing this as fixed as per bug 255008. We'll continue to track the inspector work in bug 254028. |