| Summary: | [IFC][Integration] Disable IFC for RenderVTTCue | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, graouts, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 247108 | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-10-29 20:28:43 PDT
Created attachment 463306 [details]
[fast-cq]Patch
Comment on attachment 463306 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463306&action=review > COMMIT_MESSAGE:6 > +RenderVTTCue consults with legacy line layout structures directly (it's been disabled through line-box-contain. see mediaControls.css) mediaControls.css is some old leftover that is not used at least on Apple platforms. But I suppose the modern controls ended up disabling it anyway. Committed 256139@main (ec9adcfcd3db): <https://commits.webkit.org/256139@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463306 [details]. (In reply to Antti Koivisto from comment #2) > Comment on attachment 463306 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=463306&action=review > > > COMMIT_MESSAGE:6 > > +RenderVTTCue consults with legacy line layout structures directly (it's been disabled through line-box-contain. see mediaControls.css) > > mediaControls.css is some old leftover that is not used at least on Apple > platforms. But I suppose the modern controls ended up disabling it anyway. oh ok, webinpsector shows line-box-contain Reopening to attach new patch. Created attachment 463315 [details]
[fast-cq]Patch
Found 1 new test failure: imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html Committed 256144@main (81ba4136c619): <https://commits.webkit.org/256144@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463315 [details]. |