Bug 247174

Summary:	IntlDateTimeFormat misspells timeZoneName error message `shortGeneric` as `shortGenric` (missing 'e')
Product:	WebKit	Reporter:	colobus.tankers.0o
Component:	JavaScriptCore	Assignee:	Yijia Huang <yijia_huang>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, mmaxfield, webkit-bug-importer, yijia_huang, ysuzuki
Priority:	P2	Keywords:	GoodFirstBug, InRadar
Version:	Safari 16
Hardware:	Unspecified
OS:	Unspecified

Description colobus.tankers.0o 2022-10-28 01:50:50 PDT

See https://github.com/WebKit/WebKit/blob/555067570d22e34d232f6d9967deb54a13c4d8b5/Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp#L859

Comment 1 colobus.tankers.0o 2022-10-28 01:55:05 PDT

See https://github.com/WebKit/WebKit/blob/555067570d22e34d232f6d9967deb54a13c4d8b5/Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp#L859

Comment 2 Alexey Proskuryakov 2022-10-29 10:17:30 PDT

Thank you for the report! Would you be willing to fix this? Documentation for getting started is at http://webkit.org/contributing-code/

Comment 3 Radar WebKit Bug Importer 2022-11-04 01:51:20 PDT

<rdar://problem/101951057>

Comment 4 Yijia Huang 2022-11-04 11:30:58 PDT

Pull request: https://github.com/WebKit/WebKit/pull/6142

Comment 5 EWS 2022-11-04 14:31:34 PDT

Committed 256339@main (99cf10bd628f): <https://commits.webkit.org/256339@main>

Reviewed commits have been landed. Closing PR #6142 and removing active labels.

Comment 6 colobus.tankers.0o 2022-11-09 07:18:23 PST

@Alexey that would've been nice, indeed! However I see @Yijia has already taken care of it before I was able to get back to this. 👏 Cheers!