| Summary: | [GTK] REGRESSION(255909@main): GBM dependency may be disabled by mistake | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, jmason, mcatanzaro, zdobersek |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=246812 | ||
|
Description
Michael Catanzaro
2022-10-27 09:36:23 PDT
FYI, I have USE_OPENGL_OR_ES ON and do not have GBM. The suggestion to fail the build in this case would be a regression. Adding a new build flag to condition the GBM dependency seems reasonable. Is it possible that the GBM dependencies could be resolved at runtime, as is done with GL, where we build a function table in OpenGLShims using dlsym? In this way, not the build environment but that of the user would determine whether GBM is used. If it is not present, webkit would degrade gracefully to software backing to keep WebGL operational. Zan has suggested just adding a new flag to control use of GBM. That should solve this without causing trouble for you. Pull request: https://github.com/WebKit/WebKit/pull/5907 Committed 256152@main (22e4c0386605): <https://commits.webkit.org/256152@main> Reviewed commits have been landed. Closing PR #5907 and removing active labels. |