Bug 247096

Summary: XMLSerializer.serializeToString() should support Attr node as parameter
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: XMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, ap, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2022-10-26 15:49:46 PDT 
Hi Team,

I just came across another bug / testcase, which is failing in Safari 16 / Safari TP 156:

Test Case - https://jsfiddle.net/20no3p91/show

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/271184ec08ca181a7d93eed532f3ce9efb9c0bcc

WPT Cover - Nope

Gecko - Failing similar to Webkit as of right now.

_________

Webkit Source - https://github.com/WebKit/WebKit/blob/f6f2c95eb900fce4967fbfb6586416363eb4fe7e/Source/WebCore/editing/MarkupAccumulator.cpp#L602

To do:

result.appendAttribute(downcast<Attr>(node).value());

or

appendAttribute(downcast<Attr>(node).value());

or something else totally.

NOTE - Add "Attr.h" header as well.

_____

Just wanted to create bug, so if I end up doing PR then I have something or else someone else take it up.

Thanks!
Comment 1 EWS 2022-10-28 22:47:31 PDT 
Committed 256126@main (38ce5b803b34): <https://commits.webkit.org/256126@main>

Reviewed commits have been landed. Closing PR #5835 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-10-28 22:48:19 PDT 
<rdar://problem/101705913>
Comment 3 Anne van Kesteren 2024-03-15 05:39:27 PDT 
*** Bug 20250 has been marked as a duplicate of this bug. ***