Bug 247034

Summary:	[git-webkit] Deeply inspect potential gardening commits
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	246542

Description Jonathan Bedard 2022-10-25 17:18:09 PDT

Gardening commits should not be considered "pickable." While we're pretty good at identifying commits as gardening commits, many of the strings used can also be used in legitimate commit messages. If we inspect the files changed in a commit, however, gardening commits become obvious. We can't performantly check all commits on a branch, but we can inspect every potential gardening commit.

Comment 1 Radar WebKit Bug Importer 2022-10-25 17:18:25 PDT

<rdar://problem/101568509>

Comment 2 Jonathan Bedard 2022-10-25 17:19:44 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5789

Comment 3 EWS 2022-10-26 08:09:38 PDT

Committed 256014@main (28f6affda692): <https://commits.webkit.org/256014@main>

Reviewed commits have been landed. Closing PR #5789 and removing active labels.

Comment 4 EWS 2022-10-26 08:55:10 PDT

Committed 252432.685@safari-7614-branch (d93ba4173c65): <https://commits.webkit.org/252432.685@safari-7614-branch>

Reviewed commits have been landed. Closing PR #162 and removing active labels.