Bug 246931

Summary: Omit "normal" value for line-height from font shorthand in specified style too, not just computed
Product: WebKit Reporter: Darin Adler <darin>
Component: CSSAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=246600
Bug Depends on:    
Bug Blocks: 246579    

Description Darin Adler 2022-10-23 21:20:10 PDT
After fixing bug 246600 there is this loose end. We should not serialize " / normal" for line-height even in specified style.
Comment 1 Darin Adler 2022-10-23 21:30:12 PDT
The tests are unambiguous about this, although the standard is a little bit ambiguous. Either way, this should be straightforward.
Comment 2 Radar WebKit Bug Importer 2022-10-23 23:21:17 PDT
<rdar://problem/101487839>
Comment 3 Darin Adler 2022-10-24 21:10:48 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5733
Comment 4 EWS 2022-10-25 16:51:59 PDT
Committed 255993@main (1d29cf3005f2): <https://commits.webkit.org/255993@main>

Reviewed commits have been landed. Closing PR #5733 and removing active labels.