Bug 246909
| Summary: | font-style: oblique with calc() should allow out-of-range angles, and clamp them for computed style | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 246579 | ||
Tim Nguyen (:ntim)
`font-style: oblique calc(91deg)` is allowed but should be clamped to `font-style: oblique 90deg`
Ditto for `font-style: oblique calc(-91deg)`
See: https://drafts.csswg.org/css-values-3/#calc-range
WPT: https://wpt.live/css/css-fonts/variations/font-style-parsing.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101484863>
Darin Adler
This test has incorrect expectations. Either the other browsers need to change or the specification does. The specification says that clamping does not have an effect on specified values, but this test requires that calc(91deg) change into 90deg in a specified value.
imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-descriptors.html
{ value: "oblique calc(91deg)", isValid: true, expectedValue: "oblique 90deg", description: "'oblique' followed by calc with out of range value (should be clamped)" },
{ value: "oblique calc(-91deg)", isValid: true, expectedValue: "oblique -90deg", description: "'oblique' followed by calc with out of range value (should be clamped)" },
Tim, maybe you can help me figure out what to do.
Darin Adler
Pull request: https://github.com/WebKit/WebKit/pull/5695
EWS
Committed 255925@main (0effe5fb60bb): <https://commits.webkit.org/255925@main>
Reviewed commits have been landed. Closing PR #5695 and removing active labels.