Bug 246869

Summary: REGRESSION(255399@main-255410@main?): [ Win EWS ] 10X CSS Layout-tests are constant ImageOnlyFailures
Product: WebKit Reporter: Robert Jenner <jenner>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: dino, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Windows 10   
Attachments:
Description Flags
Image Diff Files none

Description Robert Jenner 2022-10-21 11:03:17 PDT 
The following 10 CSS Layout-tests are constant ImageOnlyFailures on Windows. We see it impacting WindowsEWS as well:

css3/filters/effect-blur.html
css3/filters/effect-combined.html
css3/filters/effect-contrast.html
css3/filters/effect-grayscale.html
css3/filters/effect-hue-rotate.html
css3/filters/effect-invert.html
css3/filters/effect-opacity.html
css3/filters/effect-saturate.html
css3/filters/effect-sepia.html
fast/css/aspect-ratio-min-height-replaced.html

HISTORY:
https://results.webkit.org/?platform=win&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=css3%2Ffilters%2Feffect-blur.html&test=css3%2Ffilters%2Feffect-combined.html&test=css3%2Ffilters%2Feffect-contrast.html&test=css3%2Ffilters%2Feffect-grayscale.html&test=css3%2Ffilters%2Feffect-hue-rotate.html&test=css3%2Ffilters%2Feffect-invert.html&test=css3%2Ffilters%2Feffect-opacity.html&test=css3%2Ffilters%2Feffect-saturate.html&test=css3%2Ffilters%2Feffect-sepia.html&test=fast%2Fcss%2Faspect-ratio-min-height-replaced.html

Results URL:
https://ews-build.s3-us-west-2.amazonaws.com/Windows-EWS/2f0fbdab-163686/results.html

Mostly they appear to be off by .01-.02%

Diff Images attached to bug.
Comment 1 Robert Jenner 2022-10-21 11:05:09 PDT 
Created attachment 463155 [details]
Image Diff Files
Comment 2 Radar WebKit Bug Importer 2022-10-21 11:06:11 PDT 
<rdar://problem/101433567>
Comment 3 EWS 2022-10-21 11:14:06 PDT 
Test gardening commit 255839@main (af55515371c8): <https://commits.webkit.org/255839@main>

Reviewed commits have been landed. Closing PR #5638 and removing active labels.
Comment 4 Robert Jenner 2022-10-21 11:22:06 PDT 
Since I don't have a Windows platform to test one I can't narrow the regression range. However, I have made a few observations: 

1. Looking at the commits in the range I believe https://commits.webkit.org/255406@main is the commit that may have introduced this regression as it modified the render element. But I am not 100% certain of this. 

2. While this does appear to be a regression, these tests MIGHT just need Image rebaselines. If that's the case I will need assistance with this because I'm unfamiliar with the process to rebase images.
Comment 5 Robert Jenner 2022-10-21 11:24:03 PDT 
(In reply to EWS from comment #3)
> Test gardening commit 255839@main (af55515371c8):
> <https://commits.webkit.org/255839@main>
> 
> Reviewed commits have been landed. Closing PR #5638 and removing active
> labels.

I have marked expectations for these tests as [ ImageOnlyFailure ] due to the negative impact on EWS.