Bug 246856

Summary:	Factorize common platform code for font feature variant
Product:	WebKit	Reporter:	Matthieu Dubet <m_dubet>
Component:	WebCore Misc.	Assignee:	Matthieu Dubet <m_dubet>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ntim, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Matthieu Dubet 2022-10-21 07:09:36 PDT

Some lengthy code (computeFeatureSettingsFromVariants ~300 lines) is exactly the same in Harfbuzz and GTK, we should factorize it.

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp#L181

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp#L84

Comment 1 Radar WebKit Bug Importer 2022-10-21 07:10:05 PDT

<rdar://problem/101426315>

Comment 2 Matthieu Dubet 2022-10-21 07:16:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5631

Comment 3 EWS 2022-10-21 12:19:09 PDT

Committed 255842@main (5535cabfe075): <https://commits.webkit.org/255842@main>

Reviewed commits have been landed. Closing PR #5631 and removing active labels.