Bug 246845

Summary:	[WebDriver] Update w3c tests with get_computed_role and get_computed_label fixes
Product:	WebKit	Reporter:	Lauro Moura <lmoura>
Component:	WebDriver	Assignee:	Carlos Garcia Campos <cgarcia>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bburg, cgarcia, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=246814 https://bugs.webkit.org/show_bug.cgi?id=246813

Description Lauro Moura 2022-10-20 21:25:58 PDT

When fixing bug246813, two tests were failing due to issues in the test cases themselves, fixed upstream in [1] in August 2022.

It'll be a reasonably big bump (last import was from December 2021 and the diff contains around 158 commits) and some extra work will be needed in the test executors. For example, it'll require changes in webkitpy's webdriver executor due to the removal of `WebDriverServer` in [2].

[1] https://github.com/web-platform-tests/wpt/commit/76cc414789e2b16ab90a7c6a0c98cfc6f2eb39f4
[2] https://github.com/web-platform-tests/wpt/commit/51c8ca12b4cbc7acd29e90038211d6c516ceb09c

Comment 1 Radar WebKit Bug Importer 2022-10-27 21:26:17 PDT

<rdar://problem/101664213>

Comment 2 Lauro Moura 2022-10-28 08:00:20 PDT

WIP patch importing https://github.com/web-platform-tests/wpt/commit/76cc414789e2b16ab90a7c6a0c98cfc6f2eb39f4 in https://github.com/lauromoura/WebKit/tree/wip-bug246845-webdriver-bump

Not sure if I was doing the right approach to replace WebDriverServer.

Comment 3 Carlos Garcia Campos 2022-11-08 01:22:04 PST

Pull request: https://github.com/WebKit/WebKit/pull/6244

Comment 4 EWS 2022-11-14 00:34:27 PST

Committed 256638@main (48b4b1609fe7): <https://commits.webkit.org/256638@main>

Reviewed commits have been landed. Closing PR #6244 and removing active labels.