Bug 246841

Summary: [WebXR] Catch undeleted GL objects with OwnedGLObject
Product: WebKit Reporter: Dan Glastonbury <djg>
Component: WebXRAssignee: Dan Glastonbury <djg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   

Dan Glastonbury
Reported 2022-10-20 19:41:14 PDT
Use OwnedGLObject to ensure that OpenGL objects are correctly released to avoid leaks. OwnedGLObject provides a reset/release interface similar to std::unique_ptr. The results of reset() and release() are marked [[nodiscard]] to signal the old value must be correctly handled. In addition, release() must be called to disarm OwnedGLObject destructor ASSERT.
Attachments
Radar WebKit Bug Importer
Comment 1 2022-10-20 19:41:28 PDT
EWS
Comment 2 2022-10-23 16:56:23 PDT
Committed 255900@main (0a69bc3f00f0): <https://commits.webkit.org/255900@main> Reviewed commits have been landed. Closing PR #5616 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.