Bug 246753

Summary:	WebGL compilation disabling WebGL 2 is broken
Product:	WebKit	Reporter:	Alejandro G. Castro <alex>
Component:	WebGL	Assignee:	Alejandro G. Castro <alex>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, Hironori.Fujii, kbr, kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Alejandro G. Castro 2022-10-19 11:17:25 PDT

WebGLVertexArrayObject is part of the WebGL 2 API but there are some places in the code where it was added under the WEBGL ifdef instead of WEBGL2

Comment 1 Alejandro G. Castro 2022-10-19 11:25:46 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5544

Comment 2 EWS 2022-10-20 01:23:37 PDT

Committed 255778@main (6b4ed06fa609): <https://commits.webkit.org/255778@main>

Reviewed commits have been landed. Closing PR #5544 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-10-20 01:24:20 PDT

<rdar://problem/101371285>

Comment 4 Fujii Hironori 2022-10-20 13:27:54 PDT

Does GTK port still need ENABLE_WEBGL2 macro?
Why don't you just remove all ENABLE_WEBGL2 macro?
IIUC, there is no port disabling ENABLE_WEBGL2 if ENABLE_WEBGL is on.

Comment 5 Alejandro G. Castro 2022-10-20 13:41:16 PDT

Apparently we are still doing it for some images we are generating for rpi devices, it would be great to do that if we don't find problems with devices that do not support opengles3.