Bug 246708

Summary:	[JSC][armv7] Disassembler should use register numbers instead of (inappropriate) names
Product:	WebKit	Reporter:	Joseph Griego <joseph.j.griego>
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Joseph Griego 2022-10-18 13:34:04 PDT

As title. The current disassembler uses e.g. "fp" for r11 and "ip" for r12 (this is the "InterProcedural link" register for calls across dsos); neither of which has the corresponding meaning inside of the JIT; (or in Thumb code generally, which uses r7 as the frame pointer)

This is a minor annoyance, but it would be nice to just use the register numbers instead.

Patch forthcoming

Comment 1 Joseph Griego 2022-10-18 13:36:46 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5510

Comment 2 Radar WebKit Bug Importer 2022-10-25 13:35:19 PDT

<rdar://problem/101559166>

Comment 3 EWS 2022-10-28 13:21:56 PDT

Committed 256113@main (51613ad86d58): <https://commits.webkit.org/256113@main>

Reviewed commits have been landed. Closing PR #5510 and removing active labels.