| Summary: | REGRESSION: [bugs.webkit.org] Linkified commit identifiers don't go to specific commit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Tools / Tests | Assignee: | lingho <lingho> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | lingho, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Ryan Haddad
2022-10-18 09:18:17 PDT
Displayed text link uses matched group 1 while generate link uses matched group 2 due to another regex handing trac.webkit.org link.
sub _replace_reference {
my $args = shift;
my $text = $args->{matches}->[0];
my $reference = $args->{matches}->[1];
return qq{<a href="https://commits.webkit.org/$reference">$text</a>};
};
My last patch left out a parentesis pair causing group 2 to be NULL.
Pull request: https://github.com/WebKit/WebKit/pull/5349 Pull request: https://github.com/WebKit/WebKit/pull/5500 Committed 255732@main (3f0b2fe64691): <https://commits.webkit.org/255732@main> Reviewed commits have been landed. Closing PR #5500 and removing active labels. |