Bug 246663

Summary:	Fire error event when link preload fails synchronously
Product:	WebKit	Reporter:	Ryan Reno <rreno>
Component:	Page Loading	Assignee:	Ryan Reno <rreno>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	beidson, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	235656

Description Ryan Reno 2022-10-17 17:23:47 PDT

The fetch and process the linked resource steps for a preload link specify we should fire an error event when there's an error returned from the fetch.

Comment 1 Radar WebKit Bug Importer 2022-10-17 17:24:06 PDT

<rdar://problem/101269688>

Comment 2 Ryan Reno 2022-10-17 17:27:34 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5473

Comment 3 Ryan Reno 2022-10-18 09:41:28 PDT

I did such a poor job of explaining the issue and naming this bug.

What we need to do is fire error events when a synchronous failure occurs. In particular, when we block the preload via CSP we don't ever schedule with the Network Process so the current code path for firing an error event never executes. Since we're supposed to return the spec's notion of a network error when we block due to CSP then we should also fire an error event when we block due to CSP.

Comment 4 EWS 2022-10-19 10:03:28 PDT

Committed 255740@main (6bab27e2e35e): <https://commits.webkit.org/255740@main>

Reviewed commits have been landed. Closing PR #5473 and removing active labels.