Bug 246653

Summary:	REGRESSION(253726@main): [ macOS wk1 Debug ] media/modern-media-controls/media-documents/click-on-video-should-not-pause.html is a flaky crash
Product:	WebKit	Reporter:	Hercules Hjalmarsson <hhjalmarsson>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	CLOSED DUPLICATE
Severity:	Normal	CC:	rackler, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Hercules Hjalmarsson 2022-10-17 14:36:19 PDT

media/modern-media-controls/media-documents/click-on-video-should-not-pause.html

Is a flaky crash on macOS wk1 Debug ToT and since 253726@main.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=media/modern-media-controls/media-documents/click-on-video-should-not-pause.html

DIFF:
ASSERTION FAILED: !needsLayout()
page/FrameView.cpp(4563) : virtual void WebCore::FrameView::paintContents(WebCore::GraphicsContext &, const WebCore::IntRect &, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext *)
1   0x108534d29 WTFCrash
2   0x18ff9ce0b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x1941fb79f WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
4   0x112e6c70c -[WebFrame(WebInternal) _drawRect:contentsOnly:]
5   0x112e906c3 -[WebHTMLView drawSingleRect:]
6   0x112e90d25 -[WebHTMLView drawRect:]
7   0x7ff815b7eed0 _NSViewDrawRect
8   0x7ff81629a13d -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
9   0x112e844b6 -[WebHTMLView(WebPrivate) _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
10  0x7ff81629a48b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
11  0x7ff81629a48b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
12  0x7ff81629a48b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
13  0x7ff815ceede5 -[NSView displayRectIgnoringOpacity:inContext:]
14  0x1924985bc WebCore::Widget::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
15  0x1944607f3 WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
16  0x194db6169 WebCore::RenderWidget::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
17  0x194db6a23 WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
18  0x194c81016 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
19  0x194c7ed8d WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
20  0x194c7b048 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
21  0x194cbad92 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_11::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const
22  0x194cba6b6 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)
23  0x194cbbaf1 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
24  0x19463fab0 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
25  0x1946fd69f WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
26  0x192127050 WebCore::PlatformCALayer::drawLayerContents(WebCore::GraphicsContext&, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, unsigned int)
27  0x19220c7f6 -[WebLayer drawInContext:]
28  0x7ff81a0b594b CABackingStoreUpdate_
29  0x7ff81a11970d invocation function for block in CA::Layer::display_()
30  0x7ff81a0b4975 -[CALayer _display]
31  0x19220d10d -[WebSimpleLayer display]

Comment 1 Radar WebKit Bug Importer 2022-10-17 14:36:38 PDT

<rdar://problem/101263540>

Comment 2 Hercules Hjalmarsson 2022-10-17 14:37:10 PDT

This issue can be bisected to 253726@main using command:

run-webkit-tests --debug -f --exit-after-n-failures 1  --force  --child-processes=5 --iterations=500 -1  media/modern-media-controls/media-documents/click-on-video-should-not-pause.html

Comment 3 EWS 2022-10-17 14:47:34 PDT

Test gardening commit 255655@main (6aef354d53ba): <https://commits.webkit.org/255655@main>

Reviewed commits have been landed. Closing PR #5461 and removing active labels.

Comment 4 Hercules Hjalmarsson 2022-10-18 14:56:46 PDT


*** This bug has been marked as a duplicate of bug 223283 ***