Bug 246561

Summary: [WGSL] Prefix AST files to avoid name clashes
Product: WebKit Reporter: Dan Glastonbury <djg>
Component: WebGPUAssignee: Dan Glastonbury <djg>
Status: RESOLVED FIXED    
Severity: Enhancement CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 246558    

Description Dan Glastonbury 2022-10-14 21:33:13 PDT
WebKit projects are built in Xcode using header maps, so each header file needs a unique name. WebGPU project has two headers named `ShaderModule.h`.

Since paths aren't used to disambiguate headers, I propose prefixing all WGSL AST node headers with `AST` and removing the nested directory structure.
Comment 1 Radar WebKit Bug Importer 2022-10-14 21:33:52 PDT
<rdar://problem/101198489>
Comment 2 Dan Glastonbury 2022-10-15 22:53:46 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5426
Comment 3 EWS 2022-10-17 00:17:09 PDT
Committed 255614@main (2b6ef0c64240): <https://commits.webkit.org/255614@main>

Reviewed commits have been landed. Closing PR #5426 and removing active labels.