Bug 246523

Summary: Fix even more misc compiler warnings, mid October 2022 edition
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   

Description Michael Catanzaro 2022-10-14 08:30:33 PDT
[1878/2405] Building CXX object Source/WebKit/CMakeFiles/...ces/WebKit/unified-sources/UnifiedSource-123a7f2f-1.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WTF/Headers/wtf/FastMalloc.h:26,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebKit/config.h:42,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebKit/Platform/LogInitialization.cpp:26,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/DerivedSources/WebKit/unified-sources/UnifiedSource-123a7f2f-1.cpp:1:
/home/mcatanzaro/Projects/WebKit/Source/WebKit/Platform/IPC/ArgumentCoders.cpp: In static member function ‘static std::optional<std::array<unsigned char, 20> > IPC::ArgumentCoder<std::array<unsigned char, 20> >::decode(IPC::Decoder&)’:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WTF/Headers/wtf/StdLibExtras.h:610:58: warning: redundant move in return statement [-Wredundant-move]
  610 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebKit/Platform/IPC/ArgumentCoders.cpp:179:12: note: in expansion of macro ‘WTFMove’
  179 |     return WTFMove(digest);
      |            ^~~~~~~
/home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WTF/Headers/wtf/StdLibExtras.h:610:58: note: remove ‘std::move’ call
  610 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebKit/Platform/IPC/ArgumentCoders.cpp:179:12: note: in expansion of macro ‘WTFMove’
  179 |     return WTFMove(digest);
      |            ^~~~~~~

[1978/2405] Building CXX object Source/WebKit/CMakeFiles/...ces/WebKit/unified-sources/UnifiedSource-88d1702b-2.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-2.cpp:7:
/home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/ProcessThrottler.cpp: In member function ‘std::optional<WebKit::ProcessAssertionType> WebKit::ProcessThrottler::assertionTypeForState(WebKit::ProcessThrottleState)’:
/home/mcatanzaro/Projects/WebKit/Source/WebKit/UIProcess/ProcessThrottler.cpp:156:1: warning: control reaches end of non-void function [-Wreturn-type]
  156 | }
Comment 1 Michael Catanzaro 2022-10-14 08:37:23 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5379
Comment 2 EWS 2022-10-17 06:06:26 PDT
Committed 255621@main (e8130b7e6a44): <https://commits.webkit.org/255621@main>

Reviewed commits have been landed. Closing PR #5379 and removing active labels.