Bug 24647
| Summary: | Add a new header file available to WebCore, WebKit and tools for configuration options | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Simon Fraser (smfr)
From bug 24396:
> > +#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> > +#define WTF_USE_ACCELERATED_COMPOSITING 0
> > +#endif
>
> I'm worried about this. Why do we have to set this up both in config.h and in
> the prefix? This should be in exactly one place. It's OK to have that one place
> be included both by the prefix and config.h, but it's not OK to repeat things
> like this. I know this configuration stuff is a mess, but I would like to keep
> it from getting even worse. Maybe there's nothing you can easily improve here.
> We could talk about this in person at some point if you like.
Agreed. I asked Mark Rowe about this and he didn't have any suggestions. We need a header that is included by all code in WebCore, WebKit and tools (DRT), and gets preprocessed after the platform defines.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |