Bug 246457

Summary:	IPC::MessageSender::sendWithAsyncReply is not consistent with send failures
Product:	WebKit	Reporter:	Kimmo Kinnunen <kkinnunen>
Component:	WebKit2	Assignee:	Kimmo Kinnunen <kkinnunen>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	achristensen, kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	247256

Description Kimmo Kinnunen 2022-10-13 06:49:48 PDT

IPC::MessageSender::sendWithAsyncReply is not consistent with send failures

When send fails, the MessageSender code has already added a pending async reply.

Comment 1 Radar WebKit Bug Importer 2022-10-13 06:50:33 PDT

<rdar://problem/101124692>

Comment 2 Kimmo Kinnunen 2022-10-13 07:08:02 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5329

Comment 3 EWS 2022-10-26 04:31:01 PDT

Committed 256008@main (b43d9276ab01): <https://commits.webkit.org/256008@main>

Reviewed commits have been landed. Closing PR #5329 and removing active labels.

Comment 4 Alex Christensen 2022-10-29 13:37:51 PDT

This broke these API tests:
TestWebKitAPI.IPCTestingAPI.CanInterceptFindString
TestWebKitAPI.IPCTestingAPI.CanInterceptHasStorageAccess

Comment 5 Alex Christensen 2022-10-29 18:08:57 PDT

https://github.com/WebKit/WebKit/pull/5940 fixes the test, though I'm not sure how the fuzzer will handle the interception of messages with replies now.