Bug 246457
| Summary: | IPC::MessageSender::sendWithAsyncReply is not consistent with send failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | WebKit2 | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 247256 | ||
Kimmo Kinnunen
IPC::MessageSender::sendWithAsyncReply is not consistent with send failures
When send fails, the MessageSender code has already added a pending async reply.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101124692>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/5329
EWS
Committed 256008@main (b43d9276ab01): <https://commits.webkit.org/256008@main>
Reviewed commits have been landed. Closing PR #5329 and removing active labels.
Alex Christensen
This broke these API tests:
TestWebKitAPI.IPCTestingAPI.CanInterceptFindString
TestWebKitAPI.IPCTestingAPI.CanInterceptHasStorageAccess
Alex Christensen
https://github.com/WebKit/WebKit/pull/5940 fixes the test, though I'm not sure how the fuzzer will handle the interception of messages with replies now.