Bug 246390

Summary:	StreamConnectionBuffer::Header field alignment isn't great enough
Product:	WebKit	Reporter:	Cameron McCormack (:heycam) <heycam>
Component:	WebKit Process Model	Assignee:	Cameron McCormack (:heycam) <heycam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Cameron McCormack (:heycam) 2022-10-11 21:28:09 PDT

StreamConnectionBuffer::Header uses alignas(sizeof(uint64_t[2])) on the second field to place it in a different CPU cache line, but that that's alignas(16). We should be using alignas(64) on x86_64 and alignas(128) on ARM64.

Comment 1 Radar WebKit Bug Importer 2022-10-11 21:28:22 PDT

<rdar://problem/101063947>

Comment 2 Cameron McCormack (:heycam) 2022-10-11 21:40:11 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5277

Comment 3 EWS 2022-10-12 21:47:36 PDT

Committed 255469@main (b9d35939c4a2): <https://commits.webkit.org/255469@main>

Reviewed commits have been landed. Closing PR #5277 and removing active labels.