Bug 246319

Summary: encode Markable values without a separate isEmpty boolean
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Web Template FrameworkAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 246322    

Description Cameron McCormack (:heycam) 2022-10-10 21:53:54 PDT
We currently encode Markable values by writing a bool first representing whether the value is the special empty value.  We should make use of the fact that the types used in Markable are designed to represent an "is empty" state without additional storage.
Comment 1 Radar WebKit Bug Importer 2022-10-10 21:54:14 PDT
<rdar://problem/101014331>
Comment 2 Cameron McCormack (:heycam) 2022-10-10 22:40:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5227
Comment 3 Cameron McCormack (:heycam) 2022-10-11 14:31:42 PDT
Decided against doing this.