Bug 246295

Summary: Misc compiler warnings, mid October 2022 edition
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   

Michael Catanzaro
Reported 2022-10-10 13:16:32 PDT
[3798/7121] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-2f84417a-10.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-2f84417a-10.cpp:6: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSValue.cpp: In member function ‘constexpr decltype(auto) WebCore::CSSValue::visitDerived(Visitor&&) [with Visitor = WebCore::CSSValue::visitDerived<WebCore::CSSValue::traverseSubresources(const WTF::Function<bool(const WebCore::CachedResource&)>&) const::<lambda(auto:95&)> >(WebCore::CSSValue::traverseSubresources(const WTF::Function<bool(const WebCore::CachedResource&)>&) const::<lambda(auto:95&)>&&) const::<lambda(auto:94&)>]’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSValue.cpp:188:1: warning: control reaches end of non-void function [-Wreturn-type] 188 | } | ^ /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSValue.cpp: In member function ‘constexpr decltype(auto) WebCore::CSSValue::visitDerived(Visitor&&) [with Visitor = WebCore::CSSValue::visitDerived<WebCore::CSSValue::equals(const WebCore::CSSValue&) const::<lambda(auto:96&)> >(WebCore::CSSValue::equals(const WebCore::CSSValue&) const::<lambda(auto:96&)>&&) const::<lambda(auto:94&)>]’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSValue.cpp:188:1: warning: control reaches end of non-void function [-Wreturn-type] /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSValue.cpp: In member function ‘constexpr decltype(auto) WebCore::CSSValue::visitDerived(Visitor&&) [with Visitor = WebCore::CSSValue::visitDerived<WebCore::CSSValue::cssText() const::<lambda(auto:97&)> >(WebCore::CSSValue::cssText() const::<lambda(auto:97&)>&&) const::<lambda(auto:94&)>]’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSValue.cpp:188:1: warning: control reaches end of non-void function [-Wreturn-type] [3802/7121] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-2f84417a-15.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-2f84417a-15.cpp:3: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/StyleRule.cpp: In member function ‘constexpr decltype(auto) WebCore::StyleRuleBase::visitDerived(Visitor&&) [with Visitor = WebCore::StyleRuleBase::visitDerived<WebCore::StyleRuleBase::copy() const::<lambda(auto:73&)> >(WebCore::StyleRuleBase::copy() const::<lambda(auto:73&)>&&) const::<lambda(auto:71&)>]’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/StyleRule.cpp:107:1: warning: control reaches end of non-void function [-Wreturn-type] 107 | } | ^ /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/StyleRule.cpp: In member function ‘constexpr decltype(auto) WebCore::StyleRuleBase::visitDerived(Visitor&&) [with Visitor = WTF::Visitor<WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRule&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRulePage&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleFontFace&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleFontPaletteValues&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleMedia&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleSupports&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleImport&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleKeyframes&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleNamespace&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleCounterStyle&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleLayer&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleContainer&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleCharset&)>, WebCore::StyleRuleBase::createCSSOMWrapper(WebCore::CSSStyleSheet*, WebCore::CSSGroupingRule*) const::<lambda(WebCore::StyleRuleKeyframe&)> >]’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/StyleRule.cpp:107:1: warning: control reaches end of non-void function [-Wreturn-type] [3885/7121] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-950a39b6-26.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WTF/Headers/wtf/FastMalloc.h:26, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/config.h:59, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp:26, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-950a39b6-26.cpp:1: /home/mcatanzaro/Projects/WebKit/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: In member function ‘WTF::RefPtr<WebCore::WebGLVertexArrayObject> WebCore::WebGL2RenderingContext::createVertexArray()’: /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WTF/Headers/wtf/StdLibExtras.h:610:58: warning: redundant move in return statement [-Wredundant-move] 610 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:2528:12: note: in expansion of macro ‘WTFMove’ 2528 | return WTFMove(object); | ^~~~~~~ /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WTF/Headers/wtf/StdLibExtras.h:610:58: note: remove ‘std::move’ call 610 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:2528:12: note: in expansion of macro ‘WTFMove’ 2528 | return WTFMove(object); | ^~~~~~~ [3947/7121] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-3c72abbe-11.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-11.cpp:6: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/VideoPixelFormat.cpp: In function ‘WebCore::VideoPixelFormat WebCore::convertVideoFramePixelFormat(uint32_t)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/VideoPixelFormat.cpp:36:56: warning: unused parameter ‘format’ [-Wunused-parameter] 36 | VideoPixelFormat convertVideoFramePixelFormat(uint32_t format) | ~~~~~~~~~^~~~~~ [4010/7121] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-3c72abbe-22.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-22.cpp:6: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/graphics/ColorBlending.cpp: In function ‘WebCore::Color WebCore::blend(const Color&, const Color&, const BlendingContext&)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/graphics/ColorBlending.cpp:152:1: warning: control reaches end of non-void function [-Wreturn-type] 152 | } | ^
Attachments
Michael Catanzaro
Comment 1 2022-10-10 13:25:10 PDT
EWS
Comment 2 2022-10-12 07:38:54 PDT
Committed 255432@main (5b0c545def4c): <https://commits.webkit.org/255432@main> Reviewed commits have been landed. Closing PR #5202 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.