| Summary: | [WinCairo][WK2] Enable EventHandlerDrivenSmoothKeyboardScrollingEnabled by default | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
| Component: | New Bugs | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | Basuke.Suzuki, darin, don.olmstead, ross.kirsling, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Fujii Hironori
2022-10-08 05:32:45 PDT
Created attachment 462879 [details]
Patch
Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 > + "PLATFORM(COCOA) || PLATFORM(WIN)": true Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows? Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review >> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 >> + "PLATFORM(COCOA) || PLATFORM(WIN)": true > > Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows? I think so, because AppleWin supports only WebKitLegacy. Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review >>> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 >>> + "PLATFORM(COCOA) || PLATFORM(WIN)": true >> >> Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows? > > I think so, because AppleWin supports only WebKitLegacy. And what causes WebKitLegacy to be unaffected by the code in EventHandler.cpp and EditorCommand.cpp that checks shouldUseSmoothKeyboardScrollingForFocusedScrollableArea()? Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review >>>> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 >>>> + "PLATFORM(COCOA) || PLATFORM(WIN)": true >>> >>> Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows? >> >> I think so, because AppleWin supports only WebKitLegacy. > > And what causes WebKitLegacy to be unaffected by the code in EventHandler.cpp and EditorCommand.cpp that checks shouldUseSmoothKeyboardScrollingForFocusedScrollableArea()? EventHandler::shouldUseSmoothKeyboardScrollingForFocusedScrollableArea returns false if the setting is disabled. And, My patch doesn't change the setting for WK1. It changes the setting only for WK2. https://github.com/WebKit/WebKit/blob/a0a26311c18df6a6b7aa596ee06ee0b4257f765a/Source/WebCore/page/EventHandler.cpp#L4439 Committed 255362@main (7bf6c5bc5c05): <https://commits.webkit.org/255362@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462879 [details]. After 255362@main (bug#246878) made the keyboard smooth scrolling depended on async scrolling, WinCairo can't scroll by keyboard at all. I should revert this patch quickly. WinCairo should re-enable it after supporting async scrolling. Created attachment 463391 [details]
[fast-cq] Patch to revert
Committed 256291@main (93fe81d68adf): <https://commits.webkit.org/256291@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463391 [details]. |