Bug 246247

Summary: [WinCairo][WK2] Enable EventHandlerDrivenSmoothKeyboardScrollingEnabled by default
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: New BugsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, darin, don.olmstead, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq] Patch to revert none

Fujii Hironori
Reported 2022-10-08 05:32:45 PDT
[WinCairo][WK2] Enable EventHandlerDrivenSmoothKeyboardScrollingEnabled by default
Attachments
Patch (1.05 KB, patch)
2022-10-08 05:34 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch to revert (1.14 KB, patch)
2022-11-03 13:37 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-10-08 05:34:40 PDT
Created attachment 462879 [details] Patch
Darin Adler
Comment 2 2022-10-09 14:31:32 PDT
Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 > + "PLATFORM(COCOA) || PLATFORM(WIN)": true Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows?
Fujii Hironori
Comment 3 2022-10-09 18:40:34 PDT
Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review >> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 >> + "PLATFORM(COCOA) || PLATFORM(WIN)": true > > Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows? I think so, because AppleWin supports only WebKitLegacy.
Darin Adler
Comment 4 2022-10-09 21:20:14 PDT
Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review >>> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 >>> + "PLATFORM(COCOA) || PLATFORM(WIN)": true >> >> Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows? > > I think so, because AppleWin supports only WebKitLegacy. And what causes WebKitLegacy to be unaffected by the code in EventHandler.cpp and EditorCommand.cpp that checks shouldUseSmoothKeyboardScrollingForFocusedScrollableArea()?
Fujii Hironori
Comment 5 2022-10-10 12:47:58 PDT
Comment on attachment 462879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462879&action=review >>>> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:278 >>>> + "PLATFORM(COCOA) || PLATFORM(WIN)": true >>> >>> Is this correct for the Apple Windows platform, the WebKit used by many versions of iTunes on Windows? >> >> I think so, because AppleWin supports only WebKitLegacy. > > And what causes WebKitLegacy to be unaffected by the code in EventHandler.cpp and EditorCommand.cpp that checks shouldUseSmoothKeyboardScrollingForFocusedScrollableArea()? EventHandler::shouldUseSmoothKeyboardScrollingForFocusedScrollableArea returns false if the setting is disabled. And, My patch doesn't change the setting for WK1. It changes the setting only for WK2. https://github.com/WebKit/WebKit/blob/a0a26311c18df6a6b7aa596ee06ee0b4257f765a/Source/WebCore/page/EventHandler.cpp#L4439
EWS
Comment 6 2022-10-10 13:42:46 PDT
Committed 255362@main (7bf6c5bc5c05): <https://commits.webkit.org/255362@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462879 [details].
Radar WebKit Bug Importer
Comment 7 2022-10-10 13:43:16 PDT
<rdar://problem/100995362>
Fujii Hironori
Comment 8 2022-11-03 13:29:43 PDT
After 255362@main (bug#246878) made the keyboard smooth scrolling depended on async scrolling, WinCairo can't scroll by keyboard at all. I should revert this patch quickly. WinCairo should re-enable it after supporting async scrolling.
Fujii Hironori
Comment 9 2022-11-03 13:37:30 PDT
Created attachment 463391 [details] [fast-cq] Patch to revert
EWS
Comment 10 2022-11-03 13:39:55 PDT
Committed 256291@main (93fe81d68adf): <https://commits.webkit.org/256291@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463391 [details].
Note You need to log in before you can comment on or make changes to this bug.