Bug 246147

Summary:	EWS can go in infinite retry loop for branch PRs when compile-webkit-without-change fails
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, jbedard, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=246518

Description Aakash Jain 2022-10-06 04:24:42 PDT

EWS can go in infinite retry loop for branch PRs when compile-webkit-without-patch fails.

e.g.: https://ews-build.webkit.org/#/builders/76/builds/844, https://ews-build.webkit.org/#/builders/76/builds/850, https://ews-build.webkit.org/#/builders/76/builds/859

Comment 1 Aakash Jain 2022-10-06 04:33:57 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5079

Comment 2 EWS 2022-10-06 08:10:08 PDT

Committed 255220@main (3dfa6716d6ad): <https://commits.webkit.org/255220@main>

Reviewed commits have been landed. Closing PR #5079 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-10-06 08:11:18 PDT

<rdar://problem/100854420>

Comment 4 Alexey Proskuryakov 2022-10-06 11:11:51 PDT

Isn't that correct and desirable behavior? We want EWS to tell if the PR is good, and checking manually is generally impossible.

I understand that retries mean more CPU time, but this change violates basic EWS guarantees.

Comment 5 Aakash Jain 2023-01-19 08:42:37 PST

*** Bug 240758 has been marked as a duplicate of this bug. ***