Bug 246088

Summary: REGRESSION(255155@main): [ iOS ] TestWebKitAPI.ServiceWorker.WindowClientNavigate constantly hits ASSERTION FAILED: m_systemObserver
Product: WebKit Reporter: Hercules Hjalmarsson <hhjalmarsson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Hercules Hjalmarsson 2022-10-05 09:00:14 PDT 
TestWebKitAPI.ServiceWorker.WindowClientNavigate

Is a constant API crash on iOS ToT and since 255155@main.

HISTORY:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.ServiceWorker.WindowClientNavigate

DIFF:
ASSERTION FAILED: m_systemObserver
platform/ios/ScreenOrientationProviderIOS.mm(99) : void WebCore::ScreenOrientationProvider::platformStopListeningForChanges()
1   0x7ff7b5b14850 (null)
2   0x12388f2e5 (null)
3   0x1f2137ab75 (null)
4   0x7ff7b5b14850 (null)
5   0x7ff7b5b14808 (null)
6   0x7ff7b5b14820 (null)
7   0x12137ad3f WTFPrintBacktrace
8   0x7ff7b5b14820 (null)
9   0x124282830 vtable for CrashLogPrintStream
10  0x1fb5b1483c (null)
11  0x7ff7b5b14850 (null)
12  0x7ff7b5b14950 (null)
13  0x12137acdc WTFReportBacktrace
14  0x7ff7b5b14850 (null)
15  0x21d6e800fb (null)
16  0x121449e0f WTFGetBacktrace
17  0x12137acc3 WTFReportBacktrace
18  0x12137adc9 WTFCrash
19  0x129f8551b WTFCrashWithInfo(int, char const*, char const*, int)
20  0x12c3f0dd4 WebCore::ScreenOrientationProvider::platformStopListeningForChanges()
21  0x12e5c6685 WebCore::ScreenOrientationProvider::removeObserver(WebCore::ScreenOrientationProvider::Observer&)
22  0x1579e2def WebKit::WebScreenOrientationManagerProxy::~WebScreenOrientationManagerProxy()
23  0x1579e2e85 WebKit::WebScreenOrientationManagerProxy::~WebScreenOrientationManagerProxy()
24  0x1578eb61b std::__1::default_delete<WebKit::WebScreenOrientationManagerProxy>::operator()(WebKit::WebScreenOrientationManagerProxy*) const
25  0x1578eb59c std::__1::unique_ptr<WebKit::WebScreenOrientationManagerProxy, std::__1::default_delete<WebKit::WebScreenOrientationManagerProxy> >::reset(WebKit::WebScreenOrientationManagerProxy*)
26  0x15787a9e1 std::__1::unique_ptr<WebKit::WebScreenOrientationManagerProxy, std::__1::default_delete<WebKit::WebScreenOrientationManagerProxy> >::operator=(std::nullptr_t)
27  0x1578477c9 WebKit::WebPageProxy::resetState(WebKit::WebPageProxy::ResetStateReason)
28  0x157879d2e WebKit::WebPageProxy::resetStateAfterProcessExited(WebKit::ProcessTerminationReason)
29  0x15785ad7a WebKit::WebPageProxy::resetStateAfterProcessTermination(WebKit::ProcessTerminationReason)
30  0x15785a691 WebKit::WebPageProxy::commitProvisionalPage(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebKit::FrameInfoData&&, WebCore::ResourceRequest&&, unsigned long long, WTF::String const&, bool, WebCore::FrameLoadType, WebCore::CertificateInfo const&, bool, bool, std::__1::optional<WebCore::HasInsecureContent>, WebCore::MouseEventPolicy, WebKit::UserData const&)
31  0x157679dbc WebKit::ProvisionalPageProxy::didCommitLoadForFrame(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, WebKit::FrameInfoData&&, WebCore::ResourceRequest&&, unsigned long long, WTF::String const&, bool, WebCore::FrameLoadType, WebCore::CertificateInfo const&, bool, bool, std::__1::optional<WebCore::HasInsecureContent>, WebCore::MouseEventPolicy, WebKit::UserData const&)
Child process terminated with signal 11: Segmentation fault
Comment 1 Radar WebKit Bug Importer 2022-10-05 09:00:37 PDT 
<rdar://problem/100809755>
Comment 2 Hercules Hjalmarsson 2022-10-05 09:00:53 PDT 
This issue can be bisected to 255155@main using command:

run-api-tests --debug --iterations=2  --ios-simulator  TestWebKitAPI.ServiceWorker.WindowClientNavigate
Comment 3 Hercules Hjalmarsson 2022-10-05 09:09:22 PDT 
Note:

This is only crashing on Debug queues.
Comment 4 Hercules Hjalmarsson 2022-10-05 13:34:24 PDT 
TestWebKitAPI.WebKit.MigrateIndexedDBDataToGeneralStorageDirectory
TestWebKitAPI.WebKit.MigrateLocalStorageDataToGeneralStorageDirectory

It appears that 2 additional API tests started crashing with the same assert. Not sure if these are related or if the commit just caused all of them to start crashing.
Comment 6 Hercules Hjalmarsson 2022-10-05 13:36:21 PDT 
(In reply to Hercules Hjalmarsson from comment #5)
> HISTORY:
> 
> https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-
> tests&test=TestWebKitAPI.WebAuthenticationPanel.
> SubFrameDestructionHidCancel&test=TestWebKitAPI.WebKit.
> MigrateLocalStorageDataToGeneralStorageDirectory&test=TestWebKitAPI.WebKit.
> MigrateIndexedDBDataToGeneralStorageDirectory

Corrected:
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebKit.MigrateLocalStorageDataToGeneralStorageDirectory&test=TestWebKitAPI.WebKit.MigrateIndexedDBDataToGeneralStorageDirectory&test=TestWebKitAPI.ServiceWorker.WindowClientNavigate
Comment 7 Chris Dumez 2022-10-06 13:03:16 PDT 
Hasn't this been fixed yesterday already? Do we have several bugs tracking the same thing?
Comment 8 Chris Dumez 2022-10-06 13:05:17 PDT 
https://commits.webkit.org/255174@main