Bug 246036

Summary: [css-grid] Layout excluded children before updateLogicalWidth
Product: WebKit Reporter: Rob Buis <rbuis>
Component: Layout and RenderingAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Rob Buis 2022-10-04 13:47:05 PDT
Layout excluded children before updateLogicalWidth.
Comment 1 Rob Buis 2022-10-04 13:48:02 PDT
Created attachment 462796 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-10-04 13:48:58 PDT
Comment on attachment 462796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462796&action=review

> COMMIT_MESSAGE:1
> +Layout excluded children before updateLogicalWidth 

This title should mention Grid.

> COMMIT_MESSAGE:6
> +Layout excluded children before calling updateLogicalWidth since

Is there a behavior change that can be tested?
Comment 3 Rob Buis 2022-10-04 22:46:22 PDT
Created attachment 462806 [details]
Patch
Comment 4 EWS 2022-10-05 03:02:40 PDT
Committed 255163@main (3a49dda1f8f6): <https://commits.webkit.org/255163@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462806 [details].
Comment 5 Radar WebKit Bug Importer 2022-10-05 03:03:17 PDT
<rdar://problem/100801246>