Bug 245984

Summary:

REGRESSION(255063@main): [ iOS ] editing/selection/ios/do-not-hide-selection-in-visible-container.html is a constant timeout

Product:

WebKit

Reporter:

Hercules Hjalmarsson <hhjalmarsson>

Component:

New Bugs

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[fast-cq]Patch	none

Description Hercules Hjalmarsson 2022-10-03 15:16:28 PDT

editing/selection/ios/do-not-hide-selection-in-visible-container.html

Is a constant timeout on iOS ToT and since 255063@main.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=editing/selection/ios/do-not-hide-selection-in-visible-container.html

DIFF:
@@ -1,18 +1,9 @@
+FAIL: Timed out waiting for notifyDone to be called

+First field  Second field  Third field  Fourth field

 Verifies that native selection UI is not suppressed when focusing an input that is inside an empty container with `overflow: hidden`, but is positioned absolutely such that it is still visible. To manually verify, click on each of the four buttons to move focus into editable areas. After tapping the first and third buttons, you should not see a caret view; after tapping the second and fourth buttons, you should see a caret view.

 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

-Waiting for caret to hide.
-PASS Caret was hidden.
-Waiting for caret to show.
-PASS Caret was shown.
-Waiting for caret to hide.
-PASS Caret was hidden.
-Waiting for caret to show.
-PASS Caret was shown.
-PASS successfullyParsed is true

-TEST COMPLETE
-

Comment 1 Radar WebKit Bug Importer 2022-10-03 15:16:48 PDT

<rdar://problem/100736393>

Comment 2 Hercules Hjalmarsson 2022-10-03 15:20:30 PDT

This issue can be bisected to 255063@main using command:

run-webkit-tests --iterations=2  --ios-simulator editing/selection/ios/do-not-hide-selection-in-visible-container.html

Comment 3 EWS 2022-10-03 15:36:17 PDT

Test gardening commit 255102@main (506efe392471): <https://commits.webkit.org/255102@main>

Reviewed commits have been landed. Closing PR #4948 and removing active labels.

Comment 4 zalan 2022-10-27 12:53:38 PDT

Created attachment 463283 [details]
[fast-cq]Patch

Comment 5 Alexey Proskuryakov 2022-10-27 15:21:51 PDT

Looks like this progressed in 255598@main

Comment 6 zalan 2022-10-27 15:35:24 PDT

(In reply to Alexey Proskuryakov from comment #5)
> Looks like this progressed in 255598@main
Yeah, I did put that in the commit message.

Comment 7 Alexey Proskuryakov 2022-10-27 15:41:52 PDT

Having it in the bug is useful too! I didn't notice it in the commit message though, so checked the history again.

Comment 8 zalan 2022-10-27 15:51:59 PDT

(In reply to Alexey Proskuryakov from comment #7)
> Having it in the bug is useful too! I didn't notice it in the commit message
> though, so checked the history again.
Indeed! I should have pre-fixed the bug (which I usually do, not sure why I didn't do it this time). Thank you.

Comment 9 zalan 2022-10-27 15:52:32 PDT

(In reply to zalan from comment #8)
> (In reply to Alexey Proskuryakov from comment #7)
> > Having it in the bug is useful too! I didn't notice it in the commit message
> > though, so checked the history again.
> Indeed! I should have pre-fixed the bug (which I usually do, not sure why I
> didn't do it this time). Thank you.
oops, not pre-fix, just include in the bug.

Comment 10 EWS 2022-10-27 18:30:51 PDT

Committed 256083@main (9b6e03ce2f66): <https://commits.webkit.org/256083@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463283 [details].