Bug 245982

Summary: [WinCairo] PageUp and PageDown keys don't start the smooth keyboard scrolling
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: Basuke.Suzuki, destra, don.olmstead, ews-watchlist, mifenton, richard_robinson2, ross.kirsling, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Description Fujii Hironori 2022-10-03 14:49:37 PDT 
[WinCairo] PageUp, PageDown, Home and End keys don't start keyboard scroll

255031@main (bug#228159) enabled EventHandlerDrivenSmoothKeyboardScrollingEnabled.
It works nicely for Arrow keys, Space key and Shift+Space key,
but for PageUp, PageDown, Home and End keys.
Comment 1 Fujii Hironori 2022-10-03 21:02:49 PDT 
241197@main (bug#229733) fixed PageUp and PageDown for the smooth keyboard scrolling.
But, 252663@main (bug#242523) removed the code.
Mac port is using EditCommand (ScrollPageBackward and ScrollPageForward) for PageUp and PageDown now.
Comment 2 Fujii Hironori 2022-10-03 21:51:26 PDT 
Created attachment 462779 [details]
WIP patch
Comment 3 Fujii Hironori 2022-10-04 22:07:20 PDT 
fast/dom/horizontal-scrollbar-in-rtl.html is failing for mac-wk2.
I will split apart EditorCommand.cpp part into another patch.
Comment 4 Fujii Hironori 2022-10-04 22:24:37 PDT 
Created attachment 462805 [details]
Patch
Comment 5 Ross Kirsling 2022-10-05 00:22:58 PDT 
Comment on attachment 462805 [details]
Patch

r=me
Comment 6 EWS 2022-10-05 02:57:00 PDT 
Committed 255162@main (c00cdc0f009b): <https://commits.webkit.org/255162@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462805 [details].
Comment 7 Radar WebKit Bug Importer 2022-10-05 02:58:18 PDT 
<rdar://problem/100801142>