Bug 245939

Summary:	[web-animations] avoid extra serialization and parsing when calling commitStyles()
Product:	WebKit	Reporter:	Antoine Quint <graouts>
Component:	Animations	Assignee:	Antoine Quint <graouts>
Status:	NEW
Severity:	Normal	CC:	dino, graouts, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Antoine Quint

Reported 2022-10-02 00:12:40 PDT

Currently WebAnimation::commitStyles() is rather inefficient as it sets new inline styles on a CSSStyleDeclaration as text, which requires serialization from the CSSValue and then parsing, and finally serializes the whole declaration before having it re-parsed once more when we call setAttribute("style", …). We should find a way to just pass around the CSSValue into the underlying data structures throughout.

Attachments
Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2022-10-02 00:18:48 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4910

Radar WebKit Bug Importer

Comment 2 2022-10-09 00:13:19 PDT

<rdar://problem/100943337>

Note You need to log in before you can comment on or make changes to this bug.