Bug 245846

Summary: Fix warnings in curl backend
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: NEW    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Don Olmstead
Reported 2022-09-29 13:32:12 PDT
Clang 15 is reporting warnings in the code C:/GitHub/WebKit/Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:158:17: error: enumeration values 'OpCodeContinuation', 'OpCodePong', and 'OpCodeInvalid' not handled in switch [-Werror,-Wswitch] switch (opCode) { ^~~~~~ C:/GitHub/WebKit/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:375:138: error: lambda capture 'isCrossOrigin' is not used [-Werror,-Wunused-lambda-capture] m_client->willPerformHTTPRedirection(WTFMove(response), WTFMove(request), [this, protectedThis = Ref { *this }, didChangeCredential, isCrossOrigin](const ResourceRequest& newRequest) { ~~^~~~~~~~~~~~~ Also check MSVC so we can turn warnings as errors on for WinCairo and PlayStation.
Attachments
Radar WebKit Bug Importer
Comment 1 2022-10-06 13:33:18 PDT
Note You need to log in before you can comment on or make changes to this bug.