Bug 245812

Summary: 'run-benchmark' should only use 'local_git_archive' when commit exists
Product: WebKit Reporter: dewei_zhu
Component: Tools / TestsAssignee: dewei_zhu
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

dewei_zhu
Reported 2022-09-28 19:27:01 PDT
Previously, it will be eligible as long as current directory is a git checkout, which does not ensure the commit/reference exists.
Attachments
Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2022-09-28 19:27:22 PDT
<rdar://problem/100539553>
dewei_zhu
Comment 2 2022-09-28 19:29:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4819
EWS
Comment 3 2022-09-29 13:46:01 PDT
Committed 255012@main (c45d27767827): <https://commits.webkit.org/255012@main> Reviewed commits have been landed. Closing PR #4819 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.