Bug 245803

Summary:	REBASELINE: [ iPadOS16 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is constantly failing
Product:	WebKit	Reporter:	Hercules Hjalmarsson <hhjalmarsson>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, karlcow, koivisto, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Hercules Hjalmarsson 2022-09-28 15:51:39 PDT

imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html

Is a constant text failure on iPadOS ToT and since introduced on the queue. It appears that it could possibly be a rebaseline issue. However, this is passing on iOS16 with the exact same expected output. Verifying before rebaselining.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html

DIFF:
@@ -383,9 +383,9 @@
 PASS -webkit-mask-position-y
 PASS -webkit-mask-source-type
 PASS -webkit-nbsp-mode
-PASS -webkit-overflow-scrolling
 PASS -webkit-rtl-ordering
 PASS -webkit-ruby-position
+PASS -webkit-tap-highlight-color
 PASS -webkit-text-combine
 PASS -webkit-text-fill-color
 PASS -webkit-text-security

Comment 1 Radar WebKit Bug Importer 2022-09-28 15:51:59 PDT

<rdar://problem/100531878>

Comment 2 Hercules Hjalmarsson 2022-09-28 15:53:26 PDT

This issue can be reproduced by using command:

run-webkit-tests --iterations=2  --ipad-simulator  imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html

Comment 3 EWS 2022-09-28 16:54:29 PDT

Test gardening commit 254980@main (663c5a893e60): <https://commits.webkit.org/254980@main>

Reviewed commits have been landed. Closing PR #4817 and removing active labels.

Comment 4 Alexey Proskuryakov 2022-09-30 18:18:16 PDT

This is a very weird failure. Why would iPadOS 16 lose -webkit-overflow-scrolling and gain -webkit-tap-highlight-color? 

Is there some crazy off-by-one bug in CSS implementation, or in the test?

Comment 5 Karl Dubost 2022-10-02 19:03:19 PDT

(for memories)
all the all-prop-initial-xml-expected.txt
https://searchfox.org/wubkat/search?q=all-prop-initial-xml-expected.txt&path=&case=false&regexp=false

Comment 6 Sam Sneddon [:gsnedders] 2022-10-07 20:58:35 PDT

(In reply to Alexey Proskuryakov from comment #4)
> This is a very weird failure. Why would iPadOS 16 lose
> -webkit-overflow-scrolling and gain -webkit-tap-highlight-color? 
> 
> Is there some crazy off-by-one bug in CSS implementation, or in the test?

-webkit-overflow-scrolling is dependent on desktop mode v. mobile mode at least (and I can't remember which mode iPadOS tests run in by default), but -webkit-tap-highlight-color should exist iff WebKit is built with touch events enabled.

Comment 7 Hercules Hjalmarsson 2022-10-20 16:08:57 PDT

This doesn't appear to be a simple re-baseline.

When running this locally (After getting the bot actual output as baseline). I'm getting,

DIFF:
@@ -387,6 +387,7 @@
 PASS -webkit-nbsp-mode
 PASS -webkit-rtl-ordering
 PASS -webkit-ruby-position
+PASS -webkit-tap-highlight-color
 PASS -webkit-text-combine
 PASS -webkit-text-fill-color
 PASS -webkit-text-security


webkit-tap-highlight-color appears to be found when running this locally with rwt compared to running this on the bot. Just re-baselining this for the bots would result in it still failing when running locally.

Comment 8 Hercules Hjalmarsson 2022-10-20 16:27:53 PDT

Setting expectation temporarily while this is being looked at.

Comment 9 EWS 2022-10-20 16:30:52 PDT

Test gardening commit 255807@main (1aa789f3371b): <https://commits.webkit.org/255807@main>

Reviewed commits have been landed. Closing PR #5607 and removing active labels.

Comment 10 Hercules Hjalmarsson 2022-10-21 12:43:16 PDT

The webkit-tap-highlight-color issue is due to build differences.

When running this with a Opensource build (similar to the bots) it's not appearing in the output. Like Sam mentioned, this issue is related to how our WebKit builds are built.

Comment 11 EWS 2022-10-21 13:45:47 PDT

Test gardening commit 255846@main (73179f061bf2): <https://commits.webkit.org/255846@main>

Reviewed commits have been landed. Closing PR #5646 and removing active labels.

Comment 12 Hercules Hjalmarsson 2022-10-21 13:46:34 PDT

(In reply to EWS from comment #11)
> Test gardening commit 255846@main (73179f061bf2):
> <https://commits.webkit.org/255846@main>
> 
> Reviewed commits have been landed. Closing PR #5646 and removing active
> labels.

The rebaseline in above commit will at least resolve this on Opensource.