Bug 245777

Summary:	[JHBuild] Update ICU to 63.1 in JHBuild minimal dependencies
Product:	WebKit	Reporter:	Diego Pino <dpino>
Component:	New Bugs	Assignee:	Diego Pino <dpino>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=229607

Description Diego Pino 2022-09-28 04:06:50 PDT

The Ubuntu 18.04 packaging bot is currently failing due a build error related to ICU after 254791@main:

https://build.webkit.org/#/builders/52/builds/592

```
FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlDurationFormat.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBUILDING_JavaScriptCore -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WPE__=1 -DGETTEXT_PACKAGE=\"WPE\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -DPKGLIBDIR=\"/usr/local/lib/wpe-webkit-1.0\" -DSTATICALLY_LINKED_WITH_WTF -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/JavaScriptCore/Headers -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/API -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/assembler -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/b3 -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/b3/air -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/bindings -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/builtins -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/bytecode -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/bytecompiler -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/dfg -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/disassembler -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/disassembler/ARM64 -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/disassembler/zydis/Zydis -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/domjit -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/ftl -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/heap -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/debugger -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/inspector -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/inspector/agents -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/inspector/augmentable -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/inspector/remote -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/interpreter -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/jit -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/llint -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/parser -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/profiler -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/runtime -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/tools -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/wasm -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/wasm/js -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/yarr -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/JavaScriptCore/DerivedSources -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/JavaScriptCore/DerivedSources/inspector -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/JavaScriptCore/DerivedSources/runtime -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/JavaScriptCore/DerivedSources/yarr -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/API/glib -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/JavaScriptCoreGLib/DerivedSources/jsc -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/JavaScriptCoreGLib/Headers -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/inspector/remote/glib -I/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/Release/WTF/Headers -isystem /home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/DependenciesWPE/Root/include/glib-2.0 -isystem /home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/WebKitBuild/DependenciesWPE/Root/lib/glib-2.0/include -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-odr -Wno-stringop-overflow -Wno-nonnull -Wno-array-bounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -ffp-contract=off -std=c++2a -MD -MT Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlDurationFormat.cpp.o -MF Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlDurationFormat.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlDurationFormat.cpp.o -c /home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/runtime/IntlDurationFormat.cpp
/home/buildbot/wpewebkit/nightly/WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804/build/Source/JavaScriptCore/runtime/IntlDurationFormat.cpp:44:10: fatal error: unicode/unumberformatter.h: No such file or directory
   44 | #include <unicode/unumberformatter.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

This bot builds with JHBuild and minimal dependencies. I checked the minimal dependencies and ICU is set to 61.2. Updating the ICU version to 63.1 (same as JHBuild full dependencies) fixes the build error.

Comment 1 Diego Pino 2022-09-28 04:09:27 PDT

Pull request: https://github.com/webkit/webkit/pull/4788

Comment 2 EWS 2022-09-28 08:53:39 PDT

Committed 254958@main (cdf5def1b8fd): <https://commits.webkit.org/254958@main>

Reviewed commits have been landed. Closing PR #4788 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-09-28 08:54:18 PDT

<rdar://problem/100510737>