Bug 245774
| Summary: | [GTK][WPE] Wrong close status code returned when the client closes a WebSocket | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
| Component: | WebKitGTK | Assignee: | Miguel Gomez <magomez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Miguel Gomez
This can reproduced with https://certification.bbctvapps.co.uk/act/test/networking/v1.3.1/websocket-client-initiated-closure/
When the WebSocket connection is closed, we return the close code provided by soup_websocket_connection_get_close_code(). But this value can be 0, which is an invalid return code, if the client abruptly closes the connection. We should return SOUP_WEBSOCKET_CLOSE_ABNORMAL in this case.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Miguel Gomez
Pull request: https://github.com/WebKit/WebKit/pull/4787
EWS
Committed 254988@main (977e507ed577): <https://commits.webkit.org/254988@main>
Reviewed commits have been landed. Closing PR #4787 and removing active labels.