Bug 245761

Summary: REGRESSION (254905@main): [ macOS Debug ] ASSERTION FAILED: document().settings().ariaReflectionForElementReferencesEnabled()
Product: WebKit Reporter: Karl Rackler <rackler>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, rego, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Karl Rackler 2022-09-27 17:18:04 PDT
Description:
accessibility/svg-remote-element.html is a consistent crash

The first failure I saw on the dashboard was on <date> at 254905@main which adds Source/WebCore/dom/Element.cpp:(WebCore::Element::isElementReflectionAttribute)

Reproduction steps:
I can reproduce this on 254905@main but cannot reproduce it on 254904@main or earlier.

Command: 
run-webkit-tests  --iterations 50 --debug-rwt-logging --no-retry --force --no-build -f --debug  accessibility/svg-remote-element.html

Result: 
Unexpected flakiness: crashes (1)
  accessibility/svg-remote-element.html [ Timeout Crash ]

History:
https://results.webkit.org/?suite=layout-tests&test=accessibility%2Fsvg-remote-element.html&platform=mac&style=debug

Crash Log:
No crash log found on bot.

stderr:
ASSERTION FAILED: document().settings().ariaReflectionForElementReferencesEnabled()
dom/Element.cpp(2099) : std::optional<Vector<RefPtr<Element>>> WebCore::Element::getElementsArrayAttribute(const WebCore::QualifiedName &) const
1   0x7ff7bdec8bb0 (null)
2   0x7382d44e5 (null)
3   0x1f35c99c65 (null)
4   0x7ff7bdec8bb0 (null)
5   0x7ff7bdec8b68 (null)
6   0x7ff7bdec8b80 (null)
7   0x735c99dff WTFPrintBacktrace
8   0x7ff7bdec8b80 (null)
9   0x738cb17a0 vtable for CrashLogPrintStream
10  0x1fbdec8b9c (null)
11  0x7ff7bdec8bb0 (null)
12  0x7ff7bdec8cb0 (null)
13  0x735c99d9f WTFReportBacktrace
14  0x7ff7bdec8bb0 (null)
15  0x21ca1300c6 (null)
16  0x735d7d56f WTFGetBacktrace
17  0x735c99d86 WTFReportBacktrace
18  0x735c99e89 WTFCrash
19  0x6e31de30b WTFCrashWithInfo(int, char const*, char const*, int)
20  0x6e6bcc3dd WebCore::Element::getElementsArrayAttribute(WebCore::QualifiedName const&) const
21  0x6e60a7b2a WebCore::AccessibilityObject::elementsFromAttribute(WebCore::QualifiedName const&) const
22  0x6e60a5473 WebCore::AccessibilityNodeObject::ariaLabeledByElements() const
23  0x6e60a7dbc WebCore::AccessibilityNodeObject::ariaLabeledByAttribute() const
24  0x6e60a2940 WebCore::AccessibilityNodeObject::ariaAccessibilityDescription() const
25  0x6e60ce7bc WebCore::AccessibilitySVGElement::accessibilityDescription() const
26  0x6e60ce6d1 WebCore::AccessibilitySVGElement::accessibilityText(WTF::Vector<WebCore::AccessibilityText, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&) const
27  0x6e3b2292e WebCore::AccessibilityObject::descriptionAttributeValue() const
28  0x6e91fd661 -[WebAccessibilityObjectWrapper accessibilityAttributeValue:]
29  0x6e0e2da03 WTR::attributeValue(objc_object*, NSString*)
30  0x6e0e2d7c3 WTR::AccessibilityUIElement::attributeValue(NSString*) const::$_2::operator()() const
31  0x6e0e2d749 WTF::Detail::CallableWrapper<WTR::AccessibilityUIElement::attributeValue(NSString*) const::$_2, void>::call()
com.apple.WebKit.WebContent.Development terminated (pid 85185) for reason: crash
LEAK: 1 WebPageProxy
Comment 1 Radar WebKit Bug Importer 2022-09-27 17:18:41 PDT
<rdar://problem/100483677>
Comment 2 Karl Rackler 2022-09-27 17:29:33 PDT
revert patch https://webkit.org/b/245762
Comment 3 Manuel Rego Casasnovas 2022-09-27 22:24:47 PDT
This will be fixed by https://github.com/WebKit/WebKit/pull/4784.

*** This bug has been marked as a duplicate of bug 244972 ***
Comment 4 Karl Rackler 2022-09-28 06:00:26 PDT
Committed 254937@main (995fb2200fc8): <https://commits.webkit.org/254937@main>

Confirmed after reverting at 254937@main the test began consistently passing again.
Comment 5 Alexey Proskuryakov 2022-09-28 10:37:50 PDT
Changing resolution to FIXED. Thank you, Karl!