Bug 245751

Summary: Set the correct style on the middle anonymous block in continuations
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, karlcow, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ahmad Saleem
Reported 2022-09-27 13:54:15 PDT
Hi Team, Based on discussions with Alan (@zalan), I will try to do "Blink Patch Merge" to see it fixes the testcase attached with the patch and it is not failing: Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/93aa8f022e5f79698d5e6ecd48f29eec8289f067 The test case is failing in Safari 16 and STP 154 as well. Link - https://jsfiddle.net/4ekf10wd/ (Show red) Thanks!
Attachments
Patch (3.58 KB, patch)
2022-10-01 22:30 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.26 KB, patch)
2022-11-03 15:47 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.65 KB, patch)
2022-11-04 07:54 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-09-27 16:02:56 PDT
I tried this in: https://github.com/WebKit/WebKit/pull/4769 but it seems that it is not simple Blink Commit merge since "containingBlock" is different in Webkit vs Blink. But since the testcase is still failing in Webkit, I would leave it open for others to follow-up. Thanks!
alan
Comment 2 2022-10-01 22:30:51 PDT
Created attachment 462759 [details] Patch
Radar WebKit Bug Importer
Comment 3 2022-10-04 13:55:19 PDT
<rdar://problem/100779471>
alan
Comment 4 2022-11-03 15:47:01 PDT
Created attachment 463392 [details] Patch
alan
Comment 5 2022-11-04 07:54:15 PDT
Created attachment 463405 [details] Patch
EWS
Comment 6 2022-11-04 09:26:38 PDT
Committed 256321@main (80d9d55a51b6): <https://commits.webkit.org/256321@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463405 [details].
Note You need to log in before you can comment on or make changes to this bug.