Bug 245737

Summary:	REGRESSION (254919@main): [iPadOS] 5X scrolling related layout tests are constant failures
Product:	WebKit	Reporter:	Hercules Hjalmarsson <hhjalmarsson>
Component:	New Bugs	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Hercules Hjalmarsson 2022-09-27 09:02:52 PDT

compositing/overflow/scrolling-content-clip-to-viewport.html
fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html 
fast/scrolling/ios/overflow-scrolling-ancestor-clip.html
fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html
compositing/rtl/rtl-scrolling-with-transformed-descendants.html

Are 5 constant text failures on iPadOS and they first started failing in the range of 254256@main-254252@main. Most likely these tests started failing at 254253@main and they all appear related. I'm not sure if this is a possible progression and these just need to be rebaselined on iPadOS.

HISTORY:
https://results.webkit.org/?limit=400&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=compositing%2Foverflow%2Fscrolling-content-clip-to-viewport.html&test=compositing%2Frtl%2Frtl-scrolling-with-transformed-descendants.html&test=fast%2Fscrolling%2Fios%2Foverflow-scrolling-ancestor-clip-size.html&test=fast%2Fscrolling%2Fios%2Foverflow-scrolling-ancestor-clip.html&test=fast%2Fscrolling%2Fios%2Fsubpixel-overflow-scrolling-with-ancestor.html

DIFFS:
--- /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt
+++ /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/compositing/overflow/scrolling-content-clip-to-viewport-actual.txt
@@ -24,10 +24,14 @@
           (bounds 320.00 340.00)
           (children 1
             (GraphicsLayer
-              (position 10.00 10.00)
-              (bounds 284.00 1204.00)
-              (contentsOpaque 1)
-              (drawsContent 1)
+              (children 1
+                (GraphicsLayer
+                  (position 10.00 10.00)
+                  (bounds 284.00 1204.00)
+                  (contentsOpaque 1)
+                  (drawsContent 1)
+                )
+              )
             )
           )
         )

--- /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt
+++ /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-actual.txt
@@ -26,16 +26,20 @@
         )
         (GraphicsLayer
           (position 8.00 8.00)
-          (bounds origin 0.00 30.00)
           (bounds 300.00 400.00)
           (children 1
             (GraphicsLayer
-              (position 20.00 50.00)
-              (bounds 260.00 800.00)
+              (bounds origin 0.00 30.00)
               (children 1
                 (GraphicsLayer
+                  (position 20.00 50.00)
                   (bounds 260.00 800.00)
-                  (contentsOpaque 1)
+                  (children 1
+                    (GraphicsLayer
+                      (bounds 260.00 800.00)
+                      (contentsOpaque 1)
+                    )
+                  )
                 )
               )
             )

--- /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt
+++ /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/fast/scrolling/ios/overflow-scrolling-ancestor-clip-actual.txt
@@ -30,16 +30,20 @@
         )
         (GraphicsLayer
           (position 9.00 9.00)
-          (bounds origin 0.00 30.00)
           (bounds 300.00 400.00)
           (children 1
             (GraphicsLayer
-              (position 20.00 50.00)
-              (bounds 260.00 800.00)
+              (bounds origin 0.00 30.00)
               (children 1
                 (GraphicsLayer
+                  (position 20.00 50.00)
                   (bounds 260.00 800.00)
-                  (contentsOpaque 1)
+                  (children 1
+                    (GraphicsLayer
+                      (bounds 260.00 800.00)
+                      (contentsOpaque 1)
+                    )
+                  )
                 )
               )
             )

--- /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt
+++ /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-actual.txt
@@ -30,16 +30,20 @@
         )
         (GraphicsLayer
           (position 19.00 19.00)
-          (bounds origin 0.00 30.00)
           (bounds 300.00 400.00)
           (children 1
             (GraphicsLayer
-              (position 20.00 50.00)
-              (bounds 260.00 800.00)
+              (bounds origin 0.00 30.00)
               (children 1
                 (GraphicsLayer
+                  (position 20.00 50.00)
                   (bounds 260.00 800.00)
-                  (contentsOpaque 1)
+                  (children 1
+                    (GraphicsLayer
+                      (bounds 260.00 800.00)
+                      (contentsOpaque 1)
+                    )
+                  )
                 )
               )
             )

--- /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt
+++ /Volumes/Data/worker/Apple-iPadOS-16-Simulator-Release-WK2-Tests/build/layout-test-results/compositing/rtl/rtl-scrolling-with-transformed-descendants-actual.txt
@@ -32,53 +32,69 @@
         )
         (GraphicsLayer
           (position 10.00 10.00)
-          (bounds origin 366.00 0.00)
           (bounds 400.00 205.00)
           (clips 1)
           (children 1
             (GraphicsLayer
-              (position 462.00 0.00)
-              (anchor 0.00 0.00)
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
+              (bounds origin 366.00 0.00)
+              (children 1
+                (GraphicsLayer
+                  (position 462.00 0.00)
+                  (anchor 0.00 0.00)
+                  (bounds 150.00 200.00)
+                  (contentsOpaque 1)
+                )
+              )
             )
           )
         )
         (GraphicsLayer
           (position 10.00 10.00)
-          (bounds origin 366.00 0.00)
           (bounds 400.00 205.00)
           (clips 1)
           (children 1
             (GraphicsLayer
-              (position 308.00 0.00)
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
+              (bounds origin 366.00 0.00)
+              (children 1
+                (GraphicsLayer
+                  (position 308.00 0.00)
+                  (bounds 150.00 200.00)
+                  (contentsOpaque 1)
+                )
+              )
             )
           )
         )
         (GraphicsLayer
           (position 10.00 10.00)
-          (bounds origin 366.00 0.00)
           (bounds 400.00 205.00)
           (clips 1)
           (children 1
             (GraphicsLayer
-              (position 154.00 0.00)
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
+              (bounds origin 366.00 0.00)
+              (children 1
+                (GraphicsLayer
+                  (position 154.00 0.00)
+                  (bounds 150.00 200.00)
+                  (contentsOpaque 1)
+                )
+              )
             )
           )
         )
         (GraphicsLayer
           (position 10.00 10.00)
-          (bounds origin 366.00 0.00)
           (bounds 400.00 205.00)
           (clips 1)
           (children 1
             (GraphicsLayer
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
+              (bounds origin 366.00 0.00)
+              (children 1
+                (GraphicsLayer
+                  (bounds 150.00 200.00)
+                  (contentsOpaque 1)
+                )
+              )
             )
           )
         )

BUILD URL:
https://build.webkit.org/results/Apple-iPadOS-16-Simulator-Release-WK2-Tests/254904@main%20(61)/results.html

Comment 1 Radar WebKit Bug Importer 2022-09-27 09:03:17 PDT

<rdar://problem/100461359>

Comment 2 Hercules Hjalmarsson 2022-09-27 09:20:26 PDT

This issue can be reproduced using command:

run-webkit-tests -f --exit-after-n-failures 1  --force  --child-processes=5 --iterations=100  --ipad-simulator compositing/overflow/scrolling-content-clip-to-viewport.html

Comment 3 EWS 2022-09-27 09:29:03 PDT

Test gardening commit 254919@main (cd2669249719): <https://commits.webkit.org/254919@main>

Reviewed commits have been landed. Closing PR #4756 and removing active labels.

Comment 4 Simon Fraser (smfr) 2022-10-03 16:14:52 PDT

Fixing this was made much harder by bug 245990 and bug 245991

Comment 5 Simon Fraser (smfr) 2022-10-03 17:06:14 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4956

Comment 6 EWS 2022-10-03 18:08:10 PDT

Test gardening commit 255104@main (f3ec83d54c53): <https://commits.webkit.org/255104@main>

Reviewed commits have been landed. Closing PR #4956 and removing active labels.

Comment 7 Hercules Hjalmarsson 2022-10-12 15:20:01 PDT

Appears resolved.