Bug 245733

Summary:

REGRESSION (254439@main): [ Monterey ] fast/text/hyphenate-avoid-orphaned-word.html is a consistent failure

Product:

WebKit

Reporter:

Karl Rackler <rackler>

Component:

New Bugs

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
[fast-cq]Patch	none

Description Karl Rackler 2022-09-27 08:16:44 PDT

Description:
fast/text/hyphenate-avoid-orphaned-word.html

This test was consistently passing until at 254439@main when it began to fail consistently.

Reproduction steps:
I can reproduce this on 254439@main but cannot reproduce it on 254438@main or earlier.

Command: 
run-webkit-tests --iterations 50 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 -f --no-retry --release  fast/text/hyphenate-avoid-orphaned-word.html

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Ftext%2Fhyphenate-avoid-orphaned-word.html&version_name=Monterey

DIFF:
@@ -17,13 +17,13 @@
           RenderText {#text} at (7,7) size 330x176
             text run at (7,7) width 245: "The chief difficulty Alice found"
             text run at (7,29) width 245: "at first was in managing her"
-            text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "-"
+            text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "\x{2010}"
             text run at (7,73) width 209: "ting its body tucked away, "
-            text run at (215,73) width 37: "com" + hyphen string "-"
+            text run at (215,73) width 37: "com" + hyphen string "\x{2010}"
             text run at (7,95) width 245: "fortably enough, under her arm,"
             text run at (7,117) width 228: "with its legs hanging down, "
             text run at (234,117) width 103: "but generally,"
-            text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "-"
+            text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "\x{2010}"
             text run at (7,161) width 39: "ened."
       RenderBlock (floating) {DIV} at (356,0) size 344x240
         RenderBlock {P} at (0,16) size 344x18
@@ -39,13 +39,13 @@
           RenderText {#text} at (7,7) size 330x176
             text run at (7,7) width 245: "The chief difficulty Alice found"
             text run at (7,29) width 245: "at first was in managing her"
-            text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "-"
+            text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "\x{2010}"
             text run at (7,73) width 209: "ting its body tucked away, "
-            text run at (215,73) width 37: "com" + hyphen string "-"
+            text run at (215,73) width 37: "com" + hyphen string "\x{2010}"
             text run at (7,95) width 245: "fortably enough, under her arm,"
             text run at (7,117) width 228: "with its legs hanging down, "
             text run at (234,117) width 103: "but generally,"
-            text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "-"
+            text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "\x{2010}"
             text run at (7,161) width 39: "ened."
       RenderBlock (floating) {DIV} at (4,240) size 344x240
         RenderBlock {P} at (0,16) size 344x18

Comment 1 Radar WebKit Bug Importer 2022-09-27 08:17:14 PDT

<rdar://problem/100459482>

Comment 2 Karl Rackler 2022-09-27 08:19:47 PDT

I have marked this test as a consistent failure while this issue is investigated.

Comment 3 EWS 2022-09-27 08:26:31 PDT

Test gardening commit 254915@main (73955d2e491c): <https://commits.webkit.org/254915@main>

Reviewed commits have been landed. Closing PR #4752 and removing active labels.

Comment 4 Darin Adler 2022-10-16 12:23:28 PDT

Not Monterey-specific. I plan to remove [ Monterey ] from the test expectation.

Comment 5 zalan 2022-10-17 16:50:06 PDT

Created attachment 463043 [details]
Patch

Comment 6 Darin Adler 2022-10-17 16:54:38 PDT

Patch needs to also include removing the failure expectation lines that were added in 254915@main

Comment 7 zalan 2022-10-17 16:56:30 PDT

(In reply to Darin Adler from comment #4)
> Not Monterey-specific. I plan to remove [ Monterey ] from the test
> expectation.
mac-bigsur still needs [hyphen string "-"] AFAICT

Comment 8 zalan 2022-10-17 16:56:51 PDT

(In reply to Darin Adler from comment #6)
> Patch needs to also include removing the failure expectation lines that were
> added in 254915@main
yeah, I just noticed it! Thanks.

Comment 9 zalan 2022-10-17 16:57:17 PDT

Created attachment 463044 [details]
[fast-cq]Patch

Comment 10 EWS 2022-10-18 05:32:03 PDT

Committed 255672@main (edc5ffd70956): <https://commits.webkit.org/255672@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463044 [details].

Comment 11 Darin Adler 2022-10-18 15:02:00 PDT

(In reply to zalan from comment #7)
> (In reply to Darin Adler from comment #4)
> > Not Monterey-specific. I plan to remove [ Monterey ] from the test
> > expectation.
> mac-bigsur still needs [hyphen string "-"] AFAICT

This shows that we should not write [ NewRelease ] when there is a difference between newer and older releases. We should write something like [ NewRelease+ ].