Bug 245718

Summary:	Fix calculation of direction for text form control elements with dir="auto"
Product:	WebKit	Reporter:	Frédéric Wang (:fredw) <fred.wang>
Component:	Forms	Assignee:	Frédéric Wang (:fredw) <fred.wang>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Frédéric Wang (:fredw) 2022-09-26 21:40:00 PDT

It's calling HTMLElement::directionalityIfDirIsAuto here but this function may sometime return a nullopt: https://searchfox.org/wubkat/rev/cf0cfbaf1ad7728a145c06e3539170870bbb913f/Source/WebCore/html/HTMLTextFormControlElement.cpp#825

Comment 1 Frédéric Wang (:fredw) 2022-09-26 21:53:53 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4741

Comment 2 EWS 2022-09-27 21:42:35 PDT

Committed 254943@main (3c75189741bc): <https://commits.webkit.org/254943@main>

Reviewed commits have been landed. Closing PR #4741 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-09-27 21:43:19 PDT

<rdar://problem/100490959>