| Summary: | AX: AXIsolatedTree::updateChildren doesn't propagate updates downwards when AccessibilityObject::m_subtreeDirty is true | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tyler Wilcock
2022-09-26 13:44:13 PDT
Created attachment 462631 [details]
Patch
Comment on attachment 462631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462631&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:598 > + if (auto* liveChild = dynamicDowncast<AccessibilityObject>(newChildren[i].get()); liveChild && liveChild->hasDirtySubtree()) this is nice to string these in a single if. is this a new ability (In reply to chris fleizach from comment #4) > Comment on attachment 462631 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=462631&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:598 > > + if (auto* liveChild = dynamicDowncast<AccessibilityObject>(newChildren[i].get()); liveChild && liveChild->hasDirtySubtree()) > > this is nice to string these in a single if. is this a new ability Indeed! It came with C++17. Committed 254899@main (523acc306f2b): <https://commits.webkit.org/254899@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462631 [details]. |