Bug 245680

Summary:	REGRESSION?(254483@main): [ iOS16 macOS wk2 ] http/tests/misc/iframe-shadow-realm.html is constantly timing out
Product:	WebKit	Reporter:	Hercules Hjalmarsson <hhjalmarsson>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mark.lam, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Hercules Hjalmarsson 2022-09-26 09:30:20 PDT

http/tests/misc/iframe-shadow-realm.html 
 
Is a constant timeout on iOS16 and macOS wk2 ToT and since 254483@main. It appears that it was expected to fail after 254483@main. However, it wasn't expected to timeout judging by the expectations set.

HISTORY: 
https://results.webkit.org/?suite=layout-tests&test=http/tests/misc/iframe-shadow-realm.html 

DIFF: 
@@ -1,10 +1,9 @@
+CONSOLE MESSAGE: Unhandled Promise Rejection: ReferenceError: Can't find variable: ShadowRealm
+FAIL: Timed out waiting for notifyDone to be called
+
 Test that shadow realms can load modules from different-origin iframe contexts
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS event.data is 42
-PASS successfullyParsed is true
 
-TEST COMPLETE
-

Comment 1 Radar WebKit Bug Importer 2022-09-26 09:30:49 PDT

<rdar://problem/100414380>

Comment 2 Hercules Hjalmarsson 2022-09-26 09:31:48 PDT

This issue can be bisected to 254483@main using command: 

run-webkit-tests --iterations=2  --ios-simulator  http/tests/misc/iframe-shadow-realm.html

Comment 3 EWS 2022-09-26 10:46:48 PDT

Test gardening commit 254869@main (a7f739402edf): <https://commits.webkit.org/254869@main>

Reviewed commits have been landed. Closing PR #4713 and removing active labels.

Comment 4 Mark Lam 2022-09-27 09:35:46 PDT

This is probably just fall out for disabling ShadowRealm.  All we need to do for this test is add this at the top of the file:

<!-- webkit-test-runner [ jscOptions=--useShadowRealm=true ] -->

Comment 5 Mark Lam 2022-09-28 08:18:33 PDT

Yusuke tells me that this test as currently written can timeout.  So, this is expected behavior.

Comment 6 EWS 2022-09-28 08:38:54 PDT

Test gardening commit 254957@main (a53a5529e983): <https://commits.webkit.org/254957@main>

Reviewed commits have been landed. Closing PR #4795 and removing active labels.

Comment 7 Mark Lam 2022-09-28 15:41:42 PDT

FYI, skipping the test is the right thing to do here (which Hercules just landed a patch for) because a test expectation of [Pass Fail Timeout] gives us no information, and wastes EWS time with time outs.