Bug 245654

Summary:	[WGSL] Gardening of WGSL parser unit tests.
Product:	WebKit	Reporter:	Dan Glastonbury <djg>
Component:	WebGPU	Assignee:	Dan Glastonbury <djg>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mmaxfield, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Dan Glastonbury

Reported 2022-09-25 22:42:02 PDT

Gardening of unit tests, including: - Add full parsing tests for complete sample vertex and fragment shaders. - Use XCTAssertTrue & XCTAssertEqual instead of XCTAssert. - Refactor tests to use auto& instead of doubling up on type names. - Add macros for common AST checks.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-09-25 22:42:41 PDT

<rdar://problem/100397595>

Dan Glastonbury

Comment 2 2022-09-25 22:59:00 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4695

EWS

Comment 3 2022-09-27 16:08:20 PDT

Committed 254932@main (0a4bde8f1d82): <https://commits.webkit.org/254932@main> Reviewed commits have been landed. Closing PR #4695 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.