Bug 245583
| Summary: | WebKit build failure since rebase of libwebrtc | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | WebRTC | Assignee: | Timothy Hatcher <timothy> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Timothy Hatcher
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:293:45: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:313:43: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:320:43: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:396:51: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:604:50: Possible misuse of comma operator here
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
youenn fablet
I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places.
Timothy Hatcher
Pull request: https://github.com/WebKit/WebKit/pull/4632
Timothy Hatcher
(In reply to youenn fablet from comment #1)
> I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places.
Oh! I will do that instead of the fix I just pushed.
Timothy Hatcher
I am not seeing the failures now after updating main.
Timothy Hatcher
I am seeing this again due to adding new files and UnifiedSources changing.
Timothy Hatcher
Pull request: https://github.com/WebKit/WebKit/pull/4666
EWS
Committed 254824@main (829b721f8a6c): <https://commits.webkit.org/254824@main>
Reviewed commits have been landed. Closing PR #4666 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/100363003>