Bug 245583

Summary:	WebKit build failure since rebase of libwebrtc
Product:	WebKit	Reporter:	Timothy Hatcher <timothy>
Component:	WebRTC	Assignee:	Timothy Hatcher <timothy>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer, youennf
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Description Timothy Hatcher 2022-09-23 09:52:26 PDT

.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:293:45: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:313:43: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:320:43: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:396:51: Possible misuse of comma operator here
.../Build/Products/Debug/usr/local/include/absl/strings/string_view.h:604:50: Possible misuse of comma operator here

Comment 1 youenn fablet 2022-09-23 09:55:19 PDT

I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places.

Comment 2 Timothy Hatcher 2022-09-23 09:56:12 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4632

Comment 3 Timothy Hatcher 2022-09-23 09:57:14 PDT

(In reply to youenn fablet from comment #1)
> I might have missed some ALLOW_COMMA_BEGIN / ALLOW_COMMA_END places.

Oh! I will do that instead of the fix I just pushed.

Comment 4 Timothy Hatcher 2022-09-23 10:31:08 PDT

I am not seeing the failures now after updating main.

Comment 5 Timothy Hatcher 2022-09-24 09:04:32 PDT

I am seeing this again due to adding new files and UnifiedSources changing.

Comment 6 Timothy Hatcher 2022-09-24 09:08:22 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4666

Comment 7 EWS 2022-09-24 09:53:55 PDT

Committed 254824@main (829b721f8a6c): <https://commits.webkit.org/254824@main>

Reviewed commits have been landed. Closing PR #4666 and removing active labels.

Comment 8 Radar WebKit Bug Importer 2022-09-24 09:54:15 PDT

<rdar://problem/100363003>