Bug 245465

Summary:	recordStrokeLineWithColorAndThickness doesn't mark the state as having applied changes.
Product:	WebKit	Reporter:	Matt Woodrow <mattwoodrow>
Component:	Layout and Rendering	Assignee:	Matt Woodrow <mattwoodrow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, george.pomas, jon, jwmerrill, paul.neave, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Matt Woodrow 2022-09-21 00:02:59 PDT

<rdar://98994290>

The recordStrokeLineWithColorAndThickness optimised path skips serialising the state object, but fails to mark that we've applied the necessary changes.

This means that you can then change state back to it's original value, and we won't detect that it changed.

Comment 1 Matt Woodrow 2022-09-21 00:05:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4560

Comment 2 Alexey Proskuryakov 2022-09-24 16:58:51 PDT

*** Bug 245145 has been marked as a duplicate of this bug. ***

Comment 3 EWS 2022-09-26 19:20:05 PDT

Committed 254889@main (aabdfc49a52b): <https://commits.webkit.org/254889@main>

Reviewed commits have been landed. Closing PR #4560 and removing active labels.

Comment 4 Alexey Proskuryakov 2022-10-16 18:59:56 PDT

*** Bug 246498 has been marked as a duplicate of this bug. ***

Comment 5 Paul Neave 2022-10-18 03:27:36 PDT

Does anyone know when this fix will make its way into Safari? Issue is still present in iOS 16.0.3 and Safari TP. Thanks.

Comment 6 Alexey Proskuryakov 2022-10-26 15:53:12 PDT

Please try it out with iOS 16.2 beta.

Apple does not comment on future releases, so we cannot discuss when it will be in shipping Safari.

Comment 7 Alexey Proskuryakov 2022-11-10 09:33:45 PST

*** Bug 247731 has been marked as a duplicate of this bug. ***