Bug 245371

Summary:	Misc compiler warnings, mid September 2022 edition
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	WebKitGTK	Assignee:	Michael Catanzaro <mcatanzaro>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, mcatanzaro
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	PC
OS:	Linux

Description Michael Catanzaro 2022-09-19 12:40:39 PDT

Fix misc compiler warnings, mid September 2022 edition

Comment 1 Michael Catanzaro 2022-09-19 12:41:34 PDT

[1318/6886] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/ShaderLang.cpp.o
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/translator/ShaderLang.cpp: In function ‘void sh::InitBuiltInResources(ShBuiltInResources*)’:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/translator/ShaderLang.cpp:181:11: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct ShBuiltInResources’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
  181 |     memset(resources, 0, sizeof(*resources));
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/translator/ShaderLang.cpp:12:
/home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h:408:8: note: ‘struct ShBuiltInResources’ declared here
  408 | struct ShBuiltInResources
      |        ^~~~~~~~~~~~~~~~~~

[3603/6886] Building CXX object Source/WebCore/CMakeFiles...vedSources/unified-sources/UnifiedSource-2f84417a-2.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-2f84417a-2.cpp:1:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In function ‘WTF::Ref<WebCore::CSSValue> WebCore::valueForAnimationTimingFunction(const TimingFunction&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1512:1: warning: control reaches end of non-void function [-Wreturn-type]
 1512 | }
      | ^

Comment 2 Michael Catanzaro 2022-09-19 12:51:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4497

Comment 3 EWS 2022-09-19 16:25:16 PDT

Committed 254652@main (93784da988d5): <https://commits.webkit.org/254652@main>

Reviewed commits have been landed. Closing PR #4497 and removing active labels.