Bug 24537

Summary: Build failure - tzname name conflict
Product: WebKit Reporter: Norbert Leser <norbert.leser>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Proposed fix for bug 24537
none
Patch update for 24537 darin: review+

Norbert Leser
Reported 2009-03-11 19:23:18 PDT
In implementation of DateMath class is a name conflict with globally defined tzname in Symbian. The proposed solution is to replace the "tzname" with different name instead of using namespace qualifier (appeared to be less clumsy). Similarly, there doesn't appear to be any reason for a conditional change. See attached patch.
Attachments
Proposed fix for bug 24537 (4.15 KB, patch)
2009-03-11 19:24 PDT, Norbert Leser 		no flags
DetailsFormatted DiffDiff
Patch update for 24537 (1.66 KB, patch)
2009-03-13 10:29 PDT, Norbert Leser 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Norbert Leser
Comment 1 2009-03-11 19:24:06 PDT
Created attachment 28513 [details] Proposed fix for bug 24537
Mark Rowe (bdash)
Comment 2 2009-03-11 19:27:13 PDT
The patch does a lot more than renaming tzname, even though that is all the changelog mentions. That's a bit misleading.
Mark Rowe (bdash)
Comment 3 2009-03-11 19:36:14 PDT
Your changelogs should also have a name rather than "Nokia User".
Norbert Leser
Comment 4 2009-03-12 08:10:23 PDT
(In reply to comment #2) > The patch does a lot more than renaming tzname, even though that is all the > changelog mentions. That's a bit misleading. > The patch has 1 more (not a lot more) changes, which is PLATFORM(SYMBIAN) conditional stuff related to DST processing. You're right, it should not have been munched together. I will separate it, update the patch and submit the symbian related stuff as a new bug report.
Norbert Leser
Comment 5 2009-03-13 10:29:03 PDT
Created attachment 28583 [details] Patch update for 24537 As discussed, I removed the SYMBIAN conditional changes from this change request (will file that at a later point separately). This new patch contains the renaming of "tzname" only.
Darin Adler
Comment 6 2009-03-13 12:16:00 PDT
Comment on attachment 28583 [details] Patch update for 24537 Seems OK. But if I had to change this, I'd prefer to change it to something less cryptic rather than more. Like timeZoneName, rather than tznm. r=me
Norbert Leser
Comment 7 2009-03-13 12:27:13 PDT
(In reply to comment #6) > (From update of attachment 28583 [details] [review]) > Seems OK. But if I had to change this, I'd prefer to change it to something > less cryptic rather than more. Like timeZoneName, rather than tznm. > > r=me > Sure, I don't mind verbose names. Do you need another patch or can you fix that directly?
Dmitry Titov
Comment 8 2009-03-13 14:54:26 PDT
Name changed and landed in: http://trac.webkit.org/changeset/41685
Note You need to log in before you can comment on or make changes to this bug.